diff --git a/observation/micrometer/src/main/java/org/neo4j/driver/observation/micrometer/DefaultBoltExchangeConvention.java b/observation/micrometer/src/main/java/org/neo4j/driver/observation/micrometer/DefaultBoltExchangeConvention.java index 9b760ae880..0dc1c6d04a 100644 --- a/observation/micrometer/src/main/java/org/neo4j/driver/observation/micrometer/DefaultBoltExchangeConvention.java +++ b/observation/micrometer/src/main/java/org/neo4j/driver/observation/micrometer/DefaultBoltExchangeConvention.java @@ -18,6 +18,7 @@ import io.micrometer.common.KeyValue; import io.micrometer.common.KeyValues; +import java.util.ArrayList; import java.util.List; public class DefaultBoltExchangeConvention implements BoltExchangeConvention { @@ -43,12 +44,17 @@ public String getContextualName(BoltExchangeContext context) { @Override public KeyValues getLowCardinalityKeyValues(BoltExchangeContext context) { - return KeyValues.of( - DB_SYSTEM_NAME, - NETWORK_PROTOCOL_NAME, - boltVersion(context), - serverAddress(context), - serverPort(context)); + return KeyValues.of(DB_SYSTEM_NAME, NETWORK_PROTOCOL_NAME, boltVersion(context), serverAddress(context)) + .and(extraLowCardinalityKeyValues(context)); + } + + private KeyValues extraLowCardinalityKeyValues(BoltExchangeContext context) { + var list = new ArrayList(); + var serverPort = serverPort(context); + if (serverPort != null) { + list.add(serverPort); + } + return KeyValues.of(list); } @Override @@ -66,8 +72,11 @@ private KeyValue serverAddress(BoltExchangeContext context) { } private KeyValue serverPort(BoltExchangeContext context) { - return Neo4jDriverDocumentation.BoltExchangeLowCardinalityKeyNames.SERVER_PORT.withValue( - String.valueOf(context.port())); + var port = context.port(); + return port >= 0 + ? Neo4jDriverDocumentation.BoltExchangeLowCardinalityKeyNames.SERVER_PORT.withValue( + String.valueOf(port)) + : null; } private KeyValue messages(BoltExchangeContext context) { diff --git a/pom.xml b/pom.xml index 1185741915..89fe031482 100644 --- a/pom.xml +++ b/pom.xml @@ -34,7 +34,7 @@ true - 8.3.0 + 8.4.0 1.0.4