Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Backup charts fails to upload backups where database name includes "backup" #356

Open
1 task done
GeoWonk opened this issue Oct 11, 2024 · 0 comments
Open
1 task done
Assignees
Labels
bug Something isn't working

Comments

@GeoWonk
Copy link

GeoWonk commented Oct 11, 2024

Contact Details

No response

What happened?

I was testing a backup pipeline with said Helm chart and a dummy database called "backup_test" failed to upload to an Azure storage account. I am unable to reproduce the output for security reasons but the console output reported it could not find a file, but the file it was looking for was not the file it had written.
I am fairly certain the error originates here where the files names are derived from regex on console output, subsequently pulling the wrong sub string and interpreting it as the file name. Assuming there is good reason to use regex instead of listing directory contents (although this is unclear to me) I think the error could be fixed by altering this line to re := regexp.MustCompile(`Finished artifact creation (.*)\.backup`) so it explicitly looks for the full stop that would not be in any database name.

Chart Name

Neo4j Admin

Chart Version

5.12.0

Environment

Microsoft Azure

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@GeoWonk GeoWonk added the bug Something isn't working label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants