-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid @default
validation rules
#5436
Comments
Many thanks for raising this bug report @MacondoExpress. 🐛 We will now attempt to reproduce the bug based on the steps you have provided. Please ensure that you've provided the necessary information for a minimal reproduction, including but not limited to:
If you have a support agreement with Neo4j, please link this GitHub issue to a new or existing Zendesk ticket. Thanks again! 🙏 |
We've been able to confirm this bug using the steps to reproduce that you provided - many thanks @MacondoExpress! 🙏 We will now prioritise the bug and address it appropriately. |
Initial PR #5437 was introduced to fix this case on the v6 POC that was dismissed and needs to be backported to v6. |
Describe the bug
Current
@default
validation does not provide the correct error message for some typeDefs.For instance:
Time
issue:Raise the following error: "@default.value is not a valid Time" with a correct
Time
value.The error in this case should be that
Time
is not supported.DateTime case:
DateTime
is a supported type, however, no validation rules happen for a List ofDateTime
values.The above, in fact, does not raise any error while
dateTime: DateTime @default(value: "dummy")
raise@default.value is not a valid DateTime
.Float case:
The
Float
type is supported, however, when not specifying the fraction part it raises an error:Raise the error: "@default.value on Float fields must be of type Float".
However, this is different from the GraphQL input specification:
https://spec.graphql.org/October2021/#sel-GAHXTHDCAACEB68G
System (please complete the following information):
The text was updated successfully, but these errors were encountered: