[N4] Whitelist of Free Contracts

[shargon]

Description

Port #4201 to N4

Type of change

• Optimization (the change is only an optimization)
• Style (the change is only a code style for better maintenance or standard purpose)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Unit Testing
• Run Application
• Local Computer Tests
• No Testing

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[Wi1l-B0t]

Coflicts

[shargon]

I will change the StorageKey Logic

[shargon]

@erikzhang We need a method for unwrap a StorageKey

[erikzhang]

I have an idea. Instead of storing the methodName and argCount directly, we can read the contract's ABI and find the method's offset.

neo/src/Neo/SmartContract/Manifest/ContractMethodDescriptor.cs

Lines 22 to 32 in c104d63

	public class ContractMethodDescriptor : ContractEventDescriptor, IEquatable<ContractMethodDescriptor>
	{
	/// <summary>
	/// Indicates the return type of the method. It can be any value of <see cref="ContractParameterType"/>.
	/// </summary>
	public ContractParameterType ReturnType { get; set; }
	/// <summary>
	/// The position of the method in the contract script.
	/// </summary>
	public int Offset { get; set; }

Once the contract is updated, all of its whitelists will become invalid. Therefore, storing only the Offset is safe.

[shargon]

It will safe storage, it's a good idea

[Wi1l-B0t]

UT Failed.