From 15996230861d3560cd52e1499848c789782b4956 Mon Sep 17 00:00:00 2001 From: "Christopher R. Schuchardt" Date: Sun, 19 Oct 2025 04:09:30 -0400 Subject: [PATCH 1/3] Move Internals to project file --- src/Neo/Neo.csproj | 2 ++ src/Neo/Properties/AssemblyInfo.cs | 5 ----- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/Neo/Neo.csproj b/src/Neo/Neo.csproj index b94d18bde3..abb5261da8 100644 --- a/src/Neo/Neo.csproj +++ b/src/Neo/Neo.csproj @@ -33,6 +33,8 @@ + + diff --git a/src/Neo/Properties/AssemblyInfo.cs b/src/Neo/Properties/AssemblyInfo.cs index 1748fefc02..21526f486a 100644 --- a/src/Neo/Properties/AssemblyInfo.cs +++ b/src/Neo/Properties/AssemblyInfo.cs @@ -9,8 +9,3 @@ // Redistribution and use in source and binary forms with or without // modifications are permitted. -using System.Runtime.CompilerServices; - -[assembly: InternalsVisibleTo("DynamicProxyGenAssembly2")] -[assembly: InternalsVisibleTo("neo.UnitTests")] -[assembly: InternalsVisibleTo("neodebug-3-adapter")] From defc2ace164debc27072455e33dfeac58ba09c31 Mon Sep 17 00:00:00 2001 From: "Christopher R. Schuchardt" Date: Sun, 19 Oct 2025 04:13:16 -0400 Subject: [PATCH 2/3] Moved more --- src/Neo.ConsoleService/Neo.ConsoleService.csproj | 4 ++++ src/Neo.ConsoleService/Properties/AssemblyInfo.cs | 14 -------------- .../Neo.Cryptography.BLS12_381.csproj | 4 ++++ .../Properties/AssemblyInfo.cs | 14 -------------- src/Neo.Json/Neo.Json.csproj | 8 ++++++++ src/Neo.Json/Properties/AssemblyInfo.cs | 14 -------------- src/Neo.VM/Neo.VM.csproj | 1 + src/Neo.VM/Properties/AssemblyInfo.cs | 14 -------------- src/Neo/Properties/AssemblyInfo.cs | 11 ----------- src/RpcClient/Properties/AssemblyInfo.cs | 14 -------------- src/RpcClient/RpcClient.csproj | 8 ++++++++ 11 files changed, 25 insertions(+), 81 deletions(-) delete mode 100644 src/Neo.ConsoleService/Properties/AssemblyInfo.cs delete mode 100644 src/Neo.Cryptography.BLS12_381/Properties/AssemblyInfo.cs delete mode 100644 src/Neo.Json/Properties/AssemblyInfo.cs delete mode 100644 src/Neo.VM/Properties/AssemblyInfo.cs delete mode 100644 src/Neo/Properties/AssemblyInfo.cs delete mode 100644 src/RpcClient/Properties/AssemblyInfo.cs diff --git a/src/Neo.ConsoleService/Neo.ConsoleService.csproj b/src/Neo.ConsoleService/Neo.ConsoleService.csproj index fd61613fca..9fdcf538a4 100644 --- a/src/Neo.ConsoleService/Neo.ConsoleService.csproj +++ b/src/Neo.ConsoleService/Neo.ConsoleService.csproj @@ -10,4 +10,8 @@ + + + + diff --git a/src/Neo.ConsoleService/Properties/AssemblyInfo.cs b/src/Neo.ConsoleService/Properties/AssemblyInfo.cs deleted file mode 100644 index ebc4cf384f..0000000000 --- a/src/Neo.ConsoleService/Properties/AssemblyInfo.cs +++ /dev/null @@ -1,14 +0,0 @@ -// Copyright (C) 2015-2025 The Neo Project. -// -// AssemblyInfo.cs file belongs to the neo project and is free -// software distributed under the MIT software license, see the -// accompanying file LICENSE in the main directory of the -// repository or http://www.opensource.org/licenses/mit-license.php -// for more details. -// -// Redistribution and use in source and binary forms with or without -// modifications are permitted. - -using System.Runtime.CompilerServices; - -[assembly: InternalsVisibleTo("Neo.ConsoleService.Tests")] diff --git a/src/Neo.Cryptography.BLS12_381/Neo.Cryptography.BLS12_381.csproj b/src/Neo.Cryptography.BLS12_381/Neo.Cryptography.BLS12_381.csproj index ca8141e2e3..724288b071 100644 --- a/src/Neo.Cryptography.BLS12_381/Neo.Cryptography.BLS12_381.csproj +++ b/src/Neo.Cryptography.BLS12_381/Neo.Cryptography.BLS12_381.csproj @@ -15,4 +15,8 @@ + + + + diff --git a/src/Neo.Cryptography.BLS12_381/Properties/AssemblyInfo.cs b/src/Neo.Cryptography.BLS12_381/Properties/AssemblyInfo.cs deleted file mode 100644 index 81b52a1269..0000000000 --- a/src/Neo.Cryptography.BLS12_381/Properties/AssemblyInfo.cs +++ /dev/null @@ -1,14 +0,0 @@ -// Copyright (C) 2015-2025 The Neo Project. -// -// AssemblyInfo.cs file belongs to the neo project and is free -// software distributed under the MIT software license, see the -// accompanying file LICENSE in the main directory of the -// repository or http://www.opensource.org/licenses/mit-license.php -// for more details. -// -// Redistribution and use in source and binary forms with or without -// modifications are permitted. - -using System.Runtime.CompilerServices; - -[assembly: InternalsVisibleTo("Neo.Cryptography.BLS12_381.Tests")] diff --git a/src/Neo.Json/Neo.Json.csproj b/src/Neo.Json/Neo.Json.csproj index 49b254d5dc..366405165c 100644 --- a/src/Neo.Json/Neo.Json.csproj +++ b/src/Neo.Json/Neo.Json.csproj @@ -11,4 +11,12 @@ + + + + + + + + diff --git a/src/Neo.Json/Properties/AssemblyInfo.cs b/src/Neo.Json/Properties/AssemblyInfo.cs deleted file mode 100644 index b446d8ff19..0000000000 --- a/src/Neo.Json/Properties/AssemblyInfo.cs +++ /dev/null @@ -1,14 +0,0 @@ -// Copyright (C) 2015-2025 The Neo Project. -// -// AssemblyInfo.cs file belongs to the neo project and is free -// software distributed under the MIT software license, see the -// accompanying file LICENSE in the main directory of the -// repository or http://www.opensource.org/licenses/mit-license.php -// for more details. -// -// Redistribution and use in source and binary forms with or without -// modifications are permitted. - -using System.Runtime.CompilerServices; - -[assembly: InternalsVisibleTo("Neo.Json.UnitTests")] diff --git a/src/Neo.VM/Neo.VM.csproj b/src/Neo.VM/Neo.VM.csproj index 446a5d29dc..3d0d05cfac 100644 --- a/src/Neo.VM/Neo.VM.csproj +++ b/src/Neo.VM/Neo.VM.csproj @@ -9,6 +9,7 @@ + diff --git a/src/Neo.VM/Properties/AssemblyInfo.cs b/src/Neo.VM/Properties/AssemblyInfo.cs deleted file mode 100644 index 7333fc53ff..0000000000 --- a/src/Neo.VM/Properties/AssemblyInfo.cs +++ /dev/null @@ -1,14 +0,0 @@ -// Copyright (C) 2015-2025 The Neo Project. -// -// AssemblyInfo.cs file belongs to the neo project and is free -// software distributed under the MIT software license, see the -// accompanying file LICENSE in the main directory of the -// repository or http://www.opensource.org/licenses/mit-license.php -// for more details. -// -// Redistribution and use in source and binary forms with or without -// modifications are permitted. - -using System.Runtime.CompilerServices; - -[assembly: InternalsVisibleTo("Neo.VM.Tests")] diff --git a/src/Neo/Properties/AssemblyInfo.cs b/src/Neo/Properties/AssemblyInfo.cs deleted file mode 100644 index 21526f486a..0000000000 --- a/src/Neo/Properties/AssemblyInfo.cs +++ /dev/null @@ -1,11 +0,0 @@ -// Copyright (C) 2015-2025 The Neo Project. -// -// AssemblyInfo.cs file belongs to the neo project and is free -// software distributed under the MIT software license, see the -// accompanying file LICENSE in the main directory of the -// repository or http://www.opensource.org/licenses/mit-license.php -// for more details. -// -// Redistribution and use in source and binary forms with or without -// modifications are permitted. - diff --git a/src/RpcClient/Properties/AssemblyInfo.cs b/src/RpcClient/Properties/AssemblyInfo.cs deleted file mode 100644 index ffe562924b..0000000000 --- a/src/RpcClient/Properties/AssemblyInfo.cs +++ /dev/null @@ -1,14 +0,0 @@ -// Copyright (C) 2015-2025 The Neo Project. -// -// AssemblyInfo.cs file belongs to the neo project and is free -// software distributed under the MIT software license, see the -// accompanying file LICENSE in the main directory of the -// repository or http://www.opensource.org/licenses/mit-license.php -// for more details. -// -// Redistribution and use in source and binary forms with or without -// modifications are permitted. - -using System.Runtime.CompilerServices; - -[assembly: InternalsVisibleTo("Neo.RpcClient.Tests")] diff --git a/src/RpcClient/RpcClient.csproj b/src/RpcClient/RpcClient.csproj index 11e37174ec..12ad38908a 100644 --- a/src/RpcClient/RpcClient.csproj +++ b/src/RpcClient/RpcClient.csproj @@ -10,4 +10,12 @@ + + + + + + + + From e60646eb28ff7891e569167b4072720b8affa648 Mon Sep 17 00:00:00 2001 From: Christopher Schuchardt <8141309+cschuchardt88@users.noreply.github.com> Date: Sat, 18 Oct 2025 23:18:15 -0900 Subject: [PATCH 3/3] Apply suggestions from code review --- src/Neo.Json/Neo.Json.csproj | 4 ---- src/RpcClient/RpcClient.csproj | 4 ---- 2 files changed, 8 deletions(-) diff --git a/src/Neo.Json/Neo.Json.csproj b/src/Neo.Json/Neo.Json.csproj index 366405165c..e2448c0c5b 100644 --- a/src/Neo.Json/Neo.Json.csproj +++ b/src/Neo.Json/Neo.Json.csproj @@ -15,8 +15,4 @@ - - - - diff --git a/src/RpcClient/RpcClient.csproj b/src/RpcClient/RpcClient.csproj index 12ad38908a..4c700d2792 100644 --- a/src/RpcClient/RpcClient.csproj +++ b/src/RpcClient/RpcClient.csproj @@ -14,8 +14,4 @@ - - - -