[N3] Whitelist of Free Contracts #4201

shargon · 2025-10-01T08:17:31Z

Selected contracts can be executed without fees, promoting adoption of stablecoins for payments and settlements.

This feature is included in the neo4 roadmap, has been discussed during CentrePoint, and is considered to be included in the next version without having to wait for neo4.

This pull request only includes the definition of the whitelist by the commit, after being accepted I will proceed to the actual consumption of this whitelist by the ApplicationEngine

Type of change

Optimization (the change is only an optimization)
Style (the change is only a code style for better maintenance or standard purpose)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Working on it after define the methods and structure

Test Configuration:

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

* 100% Coverage Trie.Get * fix ut Co-authored-by: Shargon <[email protected]>

* Makefile support for mainnet full node Dockerfile * add docker run * add container name * update doc * improve * some improvement --------- Co-authored-by: Shargon <[email protected]>

* optimize: command tokenizer * Fix: keep consistency with legacy behaviour when quote char not at first char --------- Co-authored-by: Shargon <[email protected]> Co-authored-by: NGD Admin <[email protected]>

* Fix: make the signer sign specific data * Plugin: add SignClient * Remove x64 and x86 configurations from solution file * [`ut`] 100% Coverage Trie.Get (#3952) * 100% Coverage Trie.Get * fix ut --------- Co-authored-by: NGD Admin <[email protected]> Co-authored-by: Jimmy <[email protected]> Co-authored-by: Shargon <[email protected]>

* style: make the code style of StatuePlugin more standard * Update src/Plugins/StateService/StatePlugin.cs Co-authored-by: Shargon <[email protected]> * [`ut`] 100% Coverage Trie.Get (#3952) * 100% Coverage Trie.Get * fix ut --------- Co-authored-by: Vitor Nazário Coelho <[email protected]> Co-authored-by: Shargon <[email protected]> Co-authored-by: NGD Admin <[email protected]> Co-authored-by: Jimmy <[email protected]>

… zip files after unzip (#3958) Co-authored-by: Jimmy <[email protected]>

* fix ut Co-authored-by: Shargon <[email protected]>

- Add comprehensive Contributing section to README - Document branch rules: master (stable release) vs dev (development) - Specify that all PRs must be based on dev branch, not master - Include step-by-step PR creation guidelines - Add development workflow diagram - Update table of contents to include Contributing section - Provide clear instructions for fork, branch, commit, and PR process Co-authored-by: Shargon <[email protected]> Co-authored-by: NGD Admin <[email protected]>

…3962) * [UnitTest] - Add unit tests for BigDecimal to increase code coverage * Update tests/Neo.UnitTests/UT_BigDecimal.cs --------- Co-authored-by: Shargon <[email protected]> Co-authored-by: NGD Admin <[email protected]>

* Adding unit test to increase coverage in UInt256 and UInt160. Modify some styles * Apply suggestions from code review Remove multiple blank lines * Update src/Neo/UInt160.cs Co-authored-by: Will <[email protected]> * Update src/Neo/UInt160.cs Co-authored-by: Will <[email protected]> * Fix: apply suggested changes to UInt160 and UInt256 * [UnitTest] - Add unit tests for BigDecimal to increase code coverage --------- Co-authored-by: Shargon <[email protected]> Co-authored-by: Will <[email protected]> Co-authored-by: NGD Admin <[email protected]> Co-authored-by: Jimmy <[email protected]>

* [`ut`] 100% Coverage Trie.Get (#3952) * 100% Coverage Trie.Get * fix ut * Update devcontainer.dockerfile version --------- Co-authored-by: Shargon <[email protected]> Co-authored-by: Jimmy <[email protected]>

…hod; 2. Add ShowDllNotFoundError to make exception handling clearer (#3955) Co-authored-by: Jimmy <[email protected]> Co-authored-by: NGD Admin <[email protected]> Co-authored-by: Shargon <[email protected]>

- Add comprehensive documentation for Neo persistence system class relationships - Document interface hierarchy (IStore, IStoreSnapshot, IReadOnlyStore, IWriteStore, IStoreProvider) - Explain class structure and relationships between providers, stores, snapshots, and caches - Detail cache system with DataCache, StoreCache, and ClonedCache relationships - Include data types (StorageKey, StorageItem) and enums (TrackState, SeekDirection) - Provide clear explanations of when to use each cache type - Add typical usage patterns for layered caching architecture Co-authored-by: Shargon <[email protected]>

…alize (#3966) * Optimize: Avoid stack alloc in UInt160 and UInt256 Serialize * Optimize: Avoid stack alloc in UInt160 and UInt256 Serialize --------- Co-authored-by: Shargon <[email protected]>

* Add log * Rename * OnNewSnapshot rename * Update src/Neo/Persistence/DataCache.cs --------- Co-authored-by: Will <[email protected]>

…#3972) * Optimize: keep more exception info when UInt160.Parse and UInt256.Parse throw exception * Update src/Neo.Extensions/StringExtensions.cs Co-authored-by: Christopher Schuchardt <[email protected]> * Optimize: keep more exception info when UInt160.Parse and UInt256.Parse throw exception * Update src/Neo/UInt160.cs --------- Co-authored-by: Christopher Schuchardt <[email protected]> Co-authored-by: Shargon <[email protected]>

* Style MPT * format

Add a couple of compatibility edge-cases, ref. nspcc-dev/neo-go#3926. Signed-off-by: Anna Shaleva <[email protected]>

Co-authored-by: Shargon <[email protected]>

Co-authored-by: Jimmy <[email protected]>

Co-authored-by: Will <[email protected]>

* Add: more exception info when throw exception * Update src/Neo/SmartContract/Native/PolicyContract.cs Co-authored-by: Shargon <[email protected]> * Update src/Neo/SmartContract/Native/PolicyContract.cs Co-authored-by: Shargon <[email protected]> * Update src/Neo/SmartContract/Native/PolicyContract.cs Co-authored-by: Shargon <[email protected]> * Add: more exception info when throw exception --------- Co-authored-by: Shargon <[email protected]>

* Style and decorators * format --------- Co-authored-by: Will <[email protected]>

Co-authored-by: Jimmy <[email protected]>

…roject/neo into whitelisted-fee-definition

erikzhang · 2025-11-11T10:49:43Z

src/Neo/SmartContract/Native/PolicyContract.cs

        /// </summary>
        private const string MillisecondsPerBlockChangedEventName = "MillisecondsPerBlockChanged";

+        private const string WhitelistChangedEventName = "WhitelistChanged";


We should rename this event. Because we may have other "whitelist" in the future.

What names does propose? WhitelistFeeChanged ?

@erikzhang event name changed

shargon · 2025-11-11T16:32:39Z

Ping @neo-project/core

ajara87 · 2025-11-17T19:09:03Z

Conflicts

shargon · 2025-11-25T10:35:44Z

@superboyiii could you test that is working as expected, with native and non native contracts? I want to merge this pr in few days (today or tomorrow)

shargon · 2025-11-25T16:33:27Z

Tests will be moved to #4340, this PR will be merged in few hours if there is no new opinions

NGDAdmin and others added 30 commits May 22, 2025 08:05

[ut] 100% Coverage Trie.Get (#3952) (#3957)

67e4975

* 100% Coverage Trie.Get * fix ut Co-authored-by: Shargon <[email protected]>

New Dockerfile, New Makefile (#3954)

d3b943a

* Makefile support for mainnet full node Dockerfile * add docker run * add container name * update doc * improve * some improvement --------- Co-authored-by: Shargon <[email protected]>

[Optimize]: command tokenizer (#3918)

39b37b5

* optimize: command tokenizer * Fix: keep consistency with legacy behaviour when quote char not at first char --------- Co-authored-by: Shargon <[email protected]> Co-authored-by: NGD Admin <[email protected]>

Fix BigDecimal (#3963)

4bd86c7

Optimize: 1. add show usage if arg not provided; 2. remove downloaded…

4f0c588

… zip files after unzip (#3958) Co-authored-by: Jimmy <[email protected]>

* 100% Coverage Trie.Get (#3964)

a6585bb

* fix ut Co-authored-by: Shargon <[email protected]>

Update devcontainer.dockerfile version (#3965)

7181c93

* [`ut`] 100% Coverage Trie.Get (#3952) * 100% Coverage Trie.Get * fix ut * Update devcontainer.dockerfile version --------- Co-authored-by: Shargon <[email protected]> Co-authored-by: Jimmy <[email protected]>

Optimzie: 1. Merge duplicated code in MainService to a LoadScript met…

452f9a5

…hod; 2. Add ShowDllNotFoundError to make exception handling clearer (#3955) Co-authored-by: Jimmy <[email protected]> Co-authored-by: NGD Admin <[email protected]> Co-authored-by: Shargon <[email protected]>

Optimize: Remove unnecessary stackalloc in UInt160 and UInt256 Seri…

a2cd7ef

…alize (#3966) * Optimize: Avoid stack alloc in UInt160 and UInt256 Serialize * Optimize: Avoid stack alloc in UInt160 and UInt256 Serialize --------- Co-authored-by: Shargon <[email protected]>

[feature] Storage events (#3967)

2378848

* Add log * Rename * OnNewSnapshot rename * Update src/Neo/Persistence/DataCache.cs --------- Co-authored-by: Will <[email protected]>

Change to official repo (#3977)

9071acc

Reduce cache access (#3979)

142b713

[style] Style MPT project (#3980)

ed1cf40

* Style MPT * format

tests: extend StdLib's unit tests (#3986)

fb95b4a

Add a couple of compatibility edge-cases, ref. nspcc-dev/neo-go#3926. Signed-off-by: Anna Shaleva <[email protected]>

Style: fix some variable with underscore style (#3989)

ea5a56f

Optimzie: use CommonPrefixLength instead in Trie.Put (#3990)

e2e62bb

Co-authored-by: Shargon <[email protected]>

Create issue-metrics.yml (#3985)

5c8874d

Co-authored-by: Jimmy <[email protected]>

Fix: Assertion arguments should be passed in the correct order (#3999)

bed8c57

Fix not null reference (#3996)

c8d1549

Co-authored-by: Will <[email protected]>

[style] Json decorator (#3995)

de16170

* Style and decorators * format --------- Co-authored-by: Will <[email protected]>

MPTTrie clean (#3994)

f4e4706

Co-authored-by: Jimmy <[email protected]>

Fix: P/Invokes should not be visible (#4003)

538e5b4

shargon added 4 commits November 11, 2025 10:31

Merge branch 'whitelisted-fee-definition' of https://github.com/neo-p…

7ef9315

…roject/neo into whitelisted-fee-definition

Fix build

0206a7f

Fix Erik's find

bcb0dc7

Fix nullable

26d4bc3

erikzhang reviewed Nov 11, 2025

View reviewed changes

shargon added 3 commits November 11, 2025 12:25

Remove md

843fe8f

Merge branch 'master' into whitelisted-fee-definition

4ca64de

Merge branch 'master' into whitelisted-fee-definition

1c38bc6

shargon changed the base branch from master to master-n3 November 20, 2025 12:02

shargon added N3 and removed neo4 labels Nov 20, 2025

shargon changed the title ~~[N4] Whitelist of Free Contracts~~ [N3] Whitelist of Free Contracts Nov 20, 2025

shargon added the Port-to-4.x label Nov 20, 2025

shargon mentioned this pull request Nov 20, 2025

[Nov. 27] Core Dev Regular Meeting Discussion #4321

Closed

shargon added 4 commits November 21, 2025 10:18

Merge branch 'master-n3' into whitelisted-fee-definition

42d45f1

change event names & fix conflicts

8ccb4ed

Fix native

30e26bc

fix factor

779a817

ajara87 approved these changes Nov 25, 2025

View reviewed changes

shargon added Ready to Merge and removed Waiting for Review labels Nov 25, 2025

shargon mentioned this pull request Nov 25, 2025

TODO Tasks before 3.9 release #4340

Open

5 tasks

AnnaShaleva approved these changes Nov 26, 2025

View reviewed changes

shargon merged commit 934b77e into master-n3 Nov 26, 2025
6 checks passed

shargon deleted the whitelisted-fee-definition branch November 26, 2025 09:58

shargon mentioned this pull request Nov 26, 2025

[N4] Whitelist of Free Contracts #4348

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[N3] Whitelist of Free Contracts #4201

[N3] Whitelist of Free Contracts #4201

shargon commented Oct 1, 2025 •

edited

Loading

Uh oh!

erikzhang Nov 11, 2025

Uh oh!

shargon Nov 11, 2025

Uh oh!

shargon Nov 21, 2025

Uh oh!

shargon commented Nov 11, 2025

Uh oh!

ajara87 commented Nov 17, 2025

Uh oh!

shargon commented Nov 25, 2025

Uh oh!

shargon commented Nov 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

[N3] Whitelist of Free Contracts #4201

[N3] Whitelist of Free Contracts #4201

Conversation

shargon commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

erikzhang Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

shargon Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

shargon Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

shargon commented Nov 11, 2025

Uh oh!

ajara87 commented Nov 17, 2025

Uh oh!

shargon commented Nov 25, 2025

Uh oh!

shargon commented Nov 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

shargon commented Oct 1, 2025 •

edited

Loading