Skip to content

Optimize: use CommonPrefixLength instead in Trie.Put #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2025
Merged

Optimize: use CommonPrefixLength instead in Trie.Put #3990

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4954ca0
Optimzie: use CommonPrefixLength instead in Trie.Put
Wi1l-B0t Jun 7, 2025
1ad3682
Merge branch 'dev' into optimize.common-prefix
shargon Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/Neo.Cryptography.MPTTrie/Cryptography/MPTTrie/Trie.Put.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,17 @@
// modifications are permitted.

using System;
using System.Runtime.CompilerServices;

namespace Neo.Cryptography.MPTTrie
{
partial class Trie
{
[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static ReadOnlySpan<byte> CommonPrefix(ReadOnlySpan<byte> a, ReadOnlySpan<byte> b)
{
var minLen = a.Length <= b.Length ? a.Length : b.Length;
var i = 0;
if (a.Length != 0 && b.Length != 0)
{
for (i = 0; i < minLen; i++)
{
if (a[i] != b[i]) break;
}
}
return a[..i];
int offset = a.CommonPrefixLength(b);
return a[..offset];
}

public void Put(byte[] key, byte[] value)
Expand Down