Remove netstandard phase one (#4145)

* Remove netstandard phase one

* Fix reordeing using

* Remove directives

Author: ajara87

src/Directory.Build.props

@@ -36,8 +36,4 @@
     <None Include="../../.neo/README.md" Pack="true" Visible="false" PackagePath=""/>
   </ItemGroup>
 
-  <ItemGroup>
-    <Compile Include="$(MSBuildThisFileDirectory)IsExternalInit.cs" Visible="false" />
-  </ItemGroup>
-
 </Project>

src/IsExternalInit.cs

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.1;net9.0</TargetFrameworks>
+    <TargetFramework>net9.0</TargetFramework>
     <Nullable>enable</Nullable>
   </PropertyGroup>
 

src/Neo.ConsoleService/Neo.ConsoleService.csproj

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <VersionPrefix>0.3.0</VersionPrefix>
-    <TargetFrameworks>netstandard2.1;net9.0</TargetFrameworks>
+    <TargetFramework>net9.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
   </PropertyGroup>

src/Neo.Cryptography.BLS12_381/Neo.Cryptography.BLS12_381.csproj

@@ -40,11 +40,7 @@ public static int GetLowestSetBit(this BigInteger value)
         {
             if (value.Sign == 0) return -1; // special case for zero. TrailingZeroCount returns 32 in standard library.
 
-#if NET7_0_OR_GREATER
             return (int)BigInteger.TrailingZeroCount(value);
-#else
-            return TrailingZeroCount(value.ToByteArray());
-#endif
         }
 
         /// <summary>
@@ -179,11 +175,7 @@ internal static BigInteger GetLowPart(this BigInteger value, int bitCount)
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static long GetBitLength(this BigInteger value)
         {
-#if NET5_0_OR_GREATER
             return value.GetBitLength();
-#else
-            return BitLength(value);
-#endif
         }
 
         /// <summary>

src/Neo.Extensions/BigIntegerExtensions.cs

@@ -57,19 +57,7 @@ public static string ToHexString(this byte[]? value)
             if (value is null)
                 throw new ArgumentNullException(nameof(value));
 
-#if NET9_0_OR_GREATER
             return Convert.ToHexStringLower(value);
-#else
-            return string.Create(value.Length * 2, value, (span, bytes) =>
-            {
-                for (var i = 0; i < bytes.Length; i++)
-                {
-                    var b = bytes[i];
-                    span[i * 2] = s_hexChars[b >> 4];
-                    span[i * 2 + 1] = s_hexChars[b & 0xF];
-                }
-            });
-#endif
         }
 
         /// <summary>
@@ -107,19 +95,7 @@ public static string ToHexString(this byte[]? value, bool reverse = false)
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static string ToHexString(this ReadOnlySpan<byte> value)
         {
-#if NET9_0_OR_GREATER
             return Convert.ToHexStringLower(value);
-#else
-            // string.Create with ReadOnlySpan<char> not supported in NET5 or lower
-            var sb = new StringBuilder(value.Length * 2);
-            for (var i = 0; i < value.Length; i++)
-            {
-                var b = value[i];
-                sb.Append(s_hexChars[b >> 4]);
-                sb.Append(s_hexChars[b & 0xF]);
-            }
-            return sb.ToString();
-#endif
         }
 
         /// <summary>
@@ -138,15 +114,7 @@ public static string ToHexString(this ReadOnlySpan<byte> value)
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static bool NotZero(this ReadOnlySpan<byte> x)
         {
-#if NET7_0_OR_GREATER
             return x.IndexOfAnyExcept((byte)0) >= 0;
-#else
-            for (var i = 0; i < x.Length; i++)
-            {
-                if (x[i] != 0) return true;
-            }
-            return false;
-#endif
         }
     }
 }

src/Neo.Extensions/ByteExtensions.cs

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.1;net9.0</TargetFrameworks>
+    <TargetFramework>net9.0</TargetFramework>
     <Nullable>enable</Nullable>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <PackageTags>NEO;Blockchain;Extensions</PackageTags>

src/Neo.Extensions/Neo.Extensions.csproj

@@ -10,13 +10,9 @@
 // modifications are permitted.
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Runtime.CompilerServices;
 using System.Text;
-using System.Diagnostics.CodeAnalysis;
-
-#if !NET9_0_OR_GREATER
-using System.Globalization;
-#endif
 
 namespace Neo.Extensions
 {
@@ -145,18 +141,7 @@ public static byte[] HexToBytesReversed(this ReadOnlySpan<char> value)
         /// <returns>The converted byte array.</returns>
         public static byte[] HexToBytes(this ReadOnlySpan<char> value)
         {
-#if !NET9_0_OR_GREATER
-            if (value.IsEmpty)
-                return [];
-            if (value.Length % 2 == 1)
-                throw new FormatException($"value.Length({value.Length}) not multiple of 2");
-            var result = new byte[value.Length / 2];
-            for (var i = 0; i < result.Length; i++)
-                result[i] = byte.Parse(value.Slice(i * 2, 2), NumberStyles.AllowHexSpecifier);
-            return result;
-#else
             return Convert.FromHexString(value);
-#endif
         }
 
         /// <summary>

src/Neo.Extensions/StringExtensions.cs

@@ -74,12 +74,7 @@ public void Unlink()
         }
 
         protected CacheItem Head { get; } = new(default!, default!);
-
-#if NET9_0_OR_GREATER
         private readonly Lock _lock = new();
-#else
-        private readonly object _lock = new();
-#endif
 
         private readonly Dictionary<TKey, CacheItem> _innerDictionary = new(comparer);
 

src/Neo.IO/Caching/Cache.cs

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.1;net9.0</TargetFrameworks>
+    <TargetFramework>net9.0</TargetFramework>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <Nullable>enable</Nullable>
     <PackageTags>NEO;Blockchain;IO</PackageTags>