Skip to content

Commit b57c17f

Browse files
committed
Disable some overly-verbose logs that rendered DEBUG useless.
1 parent f780fb1 commit b57c17f

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

unsafe/src/main/java/org/apache/spark/unsafe/memory/TaskMemoryManager.java

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,6 @@ public TaskMemoryManager(ExecutorMemoryManager executorMemoryManager) {
101101
* intended for allocating large blocks of memory that will be shared between operators.
102102
*/
103103
public MemoryBlock allocatePage(long size) {
104-
if (logger.isTraceEnabled()) {
105-
logger.trace("Allocating {} byte page", size);
106-
}
107104
if (size >= (1L << 51)) {
108105
throw new IllegalArgumentException("Cannot allocate a page with more than 2^51 bytes");
109106
}
@@ -120,8 +117,8 @@ public MemoryBlock allocatePage(long size) {
120117
final MemoryBlock page = executorMemoryManager.allocate(size);
121118
page.pageNumber = pageNumber;
122119
pageTable[pageNumber] = page;
123-
if (logger.isDebugEnabled()) {
124-
logger.debug("Allocate page number {} ({} bytes)", pageNumber, size);
120+
if (logger.isTraceEnabled()) {
121+
logger.trace("Allocate page number {} ({} bytes)", pageNumber, size);
125122
}
126123
return page;
127124
}
@@ -130,18 +127,15 @@ public MemoryBlock allocatePage(long size) {
130127
* Free a block of memory allocated via {@link TaskMemoryManager#allocatePage(long)}.
131128
*/
132129
public void freePage(MemoryBlock page) {
133-
if (logger.isTraceEnabled()) {
134-
logger.trace("Freeing page number {} ({} bytes)", page.pageNumber, page.size());
135-
}
136130
assert (page.pageNumber != -1) :
137131
"Called freePage() on memory that wasn't allocated with allocatePage()";
138132
executorMemoryManager.free(page);
139133
synchronized (this) {
140134
allocatedPages.clear(page.pageNumber);
141135
}
142136
pageTable[page.pageNumber] = null;
143-
if (logger.isDebugEnabled()) {
144-
logger.debug("Freed page number {} ({} bytes)", page.pageNumber, page.size());
137+
if (logger.isTraceEnabled()) {
138+
logger.trace("Freed page number {} ({} bytes)", page.pageNumber, page.size());
145139
}
146140
}
147141

0 commit comments

Comments
 (0)