Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add missing parenthesis in '--matrix' command #2526

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: add missing parenthesis in '--matrix' command #2526

wants to merge 1 commit into from

Conversation

acktsap
Copy link

@acktsap acktsap commented Nov 10, 2024

Resolves #2525

@acktsap acktsap requested a review from a team as a code owner November 10, 2024 16:01
ChristopherHX
ChristopherHX approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.01%. Comparing base (5a80a04) to head (856afd0).
Report is 128 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #2526       +/-   ##
===========================================
+ Coverage   61.56%   75.01%   +13.44%     
===========================================
  Files          53       62        +9     
  Lines        9002    10013     +1011     
===========================================
+ Hits         5542     7511     +1969     
+ Misses       3020     1936     -1084     
- Partials      440      566      +126

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

allexiusw
allexiusw approved these changes Nov 16, 2024
View reviewed changes
Copy link

@allexiusw allexiusw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherHX ChristopherHX ChristopherHX approved these changes

@allexiusw allexiusw allexiusw approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing parenthesis in '--matrix' command
3 participants
@acktsap @allexiusw @ChristopherHX