Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should conda-store jupyterlab extension be re-enabled once it supports JupyterLab 4? #2302

Closed
krassowski opened this issue Mar 11, 2024 · 1 comment · Fixed by nebari-dev/nebari-docker-images#126
Labels
needs: discussion 💬 Needs discussion with the rest of the team

Comments

@krassowski
Copy link
Member

krassowski commented Mar 11, 2024

Context

Following the issue #2181 the conda-store extension for jupyterlab was disabled in nebari. Once jupyterlab-conda-store support for JupyterLab 4.x (which was merged in conda-incubator/jupyterlab-conda-store#34) is released, should default image of nebari include jupyterlab-conda-store again, or should it be an optional extension which deployments managers can install?

If this is to be an optional extension, addressing #2299 might be of a higher priority.

Value and/or benefit

Users would not need to open a new page to modify their environments.

The cost of making sure that jupyterlab-conda-store supports latest JupyterLab version does not appear high to me, but I appreciate that others may disagree. I don't think it is high because excluding dependency bumping and linting, there was only one line of code change required to transition between major JupyterLab versions from 3 to 4:

-      mainMenu.addMenu(condaStoreMenu, { rank: 1000 });
+      mainMenu.addMenu(condaStoreMenu, true, { rank: 1000 });

This is because most of the code is isolated in conda-store package itself.

Anything else?

No response

@krassowski krassowski added the needs: triage 🚦 Someone needs to have a look at this issue and triage label Mar 11, 2024
@pavithraes pavithraes added needs: discussion 💬 Needs discussion with the rest of the team and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels Mar 12, 2024
@Adam-D-Lewis
Copy link
Member

I assume we would want to re-enable the extension in Nebari once it supports Jupyterhub 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: discussion 💬 Needs discussion with the rest of the team
Projects
Development

Successfully merging a pull request may close this issue.

3 participants