[CRITICAL] Lock held across async I/O boundary blocks webhook processing #869

Activity

1. ironclaw-ci

   added

   bugSomething isn't workingSomething isn't working

   risk: highSafety, secrets, auth, or critical infrastructureSafety, secrets, auth, or critical infrastructure

   staging-ci-reviewIssue found during staging CI promotion reviewIssue found during staging CI promotion review

   on Mar 10, 2026
2. henrypark133 commented on Mar 10, 2026

   

   henrypark133

   on Mar 10, 2026

   Collaborator

   More actions

   Triage verdict: Legit

   src/main.rs:754 holds tokio::sync::Mutex across async I/O (restart_with_addr().await). src/channels/http.rs:398-408 holds RwLock read guard across tx.send(msg).await, blocking other webhook handlers.
3. henrypark133

   added 4 commits that reference this issue on Mar 10, 2026

   fix: address staging-ci-review issues (batch 1)

   ...

   296859b

   fix: address staging-ci-review issues (batch 1)

   ...

   92596d8

   fix: address staging-ci-review issues (batch 1)

   ...

   93dd3d2

   fix: staging CI review issues (batch 1) (#883)

   ...

   873322f
4. qbit-glitch

   added 7 commits that reference this issue on Mar 10, 2026

   ccr: Plan: Fix nearai#869 — lock held across async I/O in 3 channel f…

   ...

   This issue will close once commit 3a7e7a8 is merged into the 'main' branch.

   3a7e7a8

   ccr: Fix nearai#869: clone sender before await in all 8 channel call …

   ...

   This issue will close once commit 939109d is merged into the 'main' branch.

   939109d

   ccr: Fix all 5 review issues from brutal code review of nearai#869

   This issue will close once commit 3044b58 is merged into the 'main' branch.

   3044b58

   fix: release lock guards before awaiting channel send (nearai#869)

   ...

   This issue will close once commit cafcef1 is merged into the 'main' branch.

   cafcef1

   fix: release lock guards before awaiting channel send (nearai#869)

   ...

   This issue will close once commit 8eb7896 is merged into the 'main' branch.

   8eb7896

   fix: release lock guards before awaiting channel send (nearai#869)

   ...

   This issue will close once commit 7d9f04a is merged into the 'main' branch.

   7d9f04a

   fix: release lock guards before awaiting channel send (nearai#869)

   ...

   This issue will close once commit 84802e1 is merged into the 'main' branch.

   84802e1
5. zmanian

   added 2 commits that reference this issue on Mar 12, 2026

   fix: release lock guards before awaiting channel send (nearai#869)

   ...

   25ffb22

   fix: release lock guards before awaiting channel send (#869) (#1003)

   ...

   ef34943
6. zmanian

   closed this as completedin #1168on Mar 14, 2026
7. bkutasi

   added 2 commits that reference this issue on Mar 28, 2026

   fix: staging CI review issues (batch 1) (nearai#883)

   ...

   3e8e82f

   fix: release lock guards before awaiting channel send (nearai#869) (n…

   ...

   f79bda4
8. drchirag1991

   added 2 commits that reference this issue on Apr 8, 2026

   fix: staging CI review issues (batch 1) (nearai#883)

   ...

   4f4aaed

   fix: release lock guards before awaiting channel send (nearai#869) (n…

   ...

   a4046f7