Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ABI package in FE+BE tsconfig.json? #211

Open
jon-lewis opened this issue Dec 16, 2022 · 0 comments
Open

Add ABI package in FE+BE tsconfig.json? #211

jon-lewis opened this issue Dec 16, 2022 · 0 comments

Comments

@jon-lewis
Copy link
Contributor

jon-lewis commented Dec 16, 2022

When performing the ABI v0.3.0 upgrade PR, there was some weird behavior with having a common typescript package (e.g. ./abi). Michael called out this behavior here.

It seems we can pull in a common TS package into the frontend without including it in the tsconfig.json (we have to do this for the backend). We would like to know why/how this is working for the frontend.

Is the backend compiling the @pc/abi code to the root node_modules and then the frontend project is using that cache? If so, we should probably include the ./abi files in the frontend/tsconfig.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant