Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol upgrade doesn't work if block producers number exceeds epoch length #12195

Open
Longarithm opened this issue Oct 8, 2024 · 0 comments
Open

Protocol upgrade doesn't work if block producers number exceeds epoch length #12195

Longarithm opened this issue Oct 8, 2024 · 0 comments
Labels
A-testing Area: Unit testing / integration testing C-housekeeping Category: Refactoring, cleanups, code quality

Comments

@Longarithm
Copy link
Member

Description

...because on finalising epoch, only votes from BPs which got chance to produce block are counted. But in percentage computation for upgrade, denominator is still the total number of BPs, and it becomes too low to pass threshold. The fix may be to decrease denominator as well in this case. It should not impact public chains anyway.
@Longarithm Longarithm added C-housekeeping Category: Refactoring, cleanups, code quality A-testing Area: Unit testing / integration testing labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing Area: Unit testing / integration testing C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Longarithm