Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epoch Sync] How to ensure block headers are available for transaction validity period check? #12142

Open
Tracked by #73
robin-near opened this issue Sep 24, 2024 · 0 comments

Comments

@robin-near
Copy link
Contributor

When a transaction is issued, it includes a block hash. The chain checks that the transaction's block hash is at most transaction_validity_period blocks old. This check requires BlockHeader to exist for the hash (not guaranteed by epoch sync currently), and requires BlockHeight to exist for the height (to check for canonical-ness).

In a case I saw, the former exists somehow (even though it was before the epoch sync boundary) but the latter does not. Not sure why that is the case - I'm confused why the header existed in storage at all.

Either way, this needs to be properly addressed.

@bowenwang1996 Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant