Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ignore: {}" interacts a bit strangely with custom hints #747

Open
langston-barrett opened this issue Aug 23, 2019 · 1 comment
Open

"ignore: {}" interacts a bit strangely with custom hints #747

langston-barrett opened this issue Aug 23, 2019 · 1 comment

Comments

@langston-barrett
Copy link

langston-barrett commented Aug 23, 2019

On this module:

module Main where
main :: IO ()
main = undefined undefined

with this config:

- ignore: {}
- error:
    name: "Only use one undefined"
    lhs: "undefined undefined"
    rhs: "undefined"

HLint 2.2.2 gives no hints. However, if I add this line:

- error: {name: "Only use one undefined"}

then HLint raises the appropriate error. Without the ignore: {}, you don't need the second error: (and you don't have to name your hint).

This isn't a show-stopper, but is a bit unexpected.

@ndmitchell
Copy link
Owner

Agreed, this is unexpected. The error is defining a hint, but that is considered separate to the configuration. I'd accept a patch fixing this, but it's probably not trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants