refactor: use size, fix watcher

Author: ndabAP

src/components/VueCommand.vue

@@ -105,6 +105,7 @@ import last from 'lodash.last'
 import eq from 'lodash.eq'
 import nth from 'lodash.nth'
 import lt from 'lodash.lt'
+import size from 'lodash.size'
 
 const props = defineProps({
   commands: {
@@ -265,11 +266,11 @@ const programs = computed(() => {
 const shouldShowHistoryEntry = computed(() => {
   return index => or(
     !local.isFullscreen,
-    and(local.isFullscreen, eq(index, local.history.length - 1))
+    and(local.isFullscreen, eq(index, size(local.history) - 1))
   )
 })
 const shouldBeFullscreen = computed(() => {
-  return index => and(local.isFullscreen, eq(index, local.history.length - 1))
+  return index => and(local.isFullscreen, eq(index, size(local.history) - 1))
 })
 
 // Removes and adds the dispatched query to enforce the quries first position

src/components/VueCommandQuery.vue

@@ -91,6 +91,7 @@ const local = reactive({
 // and parsed query if there are more than two arguments
 const autocompleteQuery = async () => {
   const query = local.query
+
   // An empty query shall be never autocompleted
   if (isEmpty(query)) {
     return
@@ -121,7 +122,7 @@ const autocompleteQuery = async () => {
       const program = head(commands)
       if (and(
         // Check if query expects autocomplete
-        lt(program.length, size(trimStart(query))),
+        lt(size(program), size(trimStart(query))),
         // Check if user provided options resolver
         isFunction(optionsResolver), isFunction(parser))
       ) {
@@ -130,7 +131,7 @@ const autocompleteQuery = async () => {
       }
 
       // If query has white spaces at the end, ignore
-      if (gt(program.length, size(trimStart(query)))) {
+      if (gt(size(program), size(trimStart(query)))) {
         setQuery(program)
       }
 
@@ -200,11 +201,12 @@ const unwatchTerminalQuery = watch(
     local.query = query
   }
 )
-const unwatchIsDisabled = watch(isOutdated, () => {
+// Free resources if query is outdated/inactive
+const unwatchIsOutdated = watch(isOutdated, () => {
   unwatchTerminalQuery()
   unwatchLocalQuery()
   unwatchTerminalCursorPosition()
-  unwatchIsDisabled()
+  unwatchIsOutdated()
   placeholder.value = ''
 })
 

src/utils/index.js

@@ -1,3 +1,5 @@
+// These are helpers for the package
+
 export const and = (x, y) => {
   return x && y
 }