Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve speed of tests #35

Open
auscompgeek opened this issue Oct 2, 2015 · 1 comment
Open

Improve speed of tests #35

auscompgeek opened this issue Oct 2, 2015 · 1 comment
Assignees

Comments

@auscompgeek
Copy link
Contributor

Currently, the tests (specifically the game tests) take a tad longer than I would hope. The tests are great, but they could be a bit faster.

@lkw657
Copy link
Contributor

lkw657 commented Apr 30, 2016

The testing code is currently running a game for every difficulty in every category with different final scores. This is completely unnecessary since it is just testing the same code execution path an excessive amount of times. It would be better if the tests had their own smaller version of the dummy data with different test cases such as less than 5 questions or an empty difficulty. In addition to it being smaller and more selective it would also mean that the same test cases are being run even if the state of the dummy data changes (i.e. more questions are added).

@lkw657 lkw657 self-assigned this Apr 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants