Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the html files #14

Open
lkw657 opened this issue Jan 15, 2015 · 3 comments
Open

Fix the html files #14

lkw657 opened this issue Jan 15, 2015 · 3 comments
Labels
bug

Comments

@lkw657
Copy link
Contributor

lkw657 commented Jan 15, 2015

The headers should contain title tags.
The header tags should be moved into the header file.
@lkw657 lkw657 added the bug label Jan 15, 2015
@auscompgeek
Copy link
Contributor

Having the <head> tags in the header file will probably cause a few issues:

  • <title> would have to be set in the handler (as in it must be, not an optional thing).
  • No corresponding footer file: confusing dangling </body> tag.
  • Having separate CSS files for different pages would become a monstrosity (i.e. simply would not work).

@auscompgeek
Copy link
Contributor

The HTML also needs to use absolute paths to the CSS files... something which Tim and I pointed out the second time around.

Edit: fixed that.

@auscompgeek
Copy link
Contributor

Alternative: have the contents of <head> in a separate head template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@auscompgeek @lkw657