From af4f996126c8dd3822fba5108a33e50a0181b02a Mon Sep 17 00:00:00 2001 From: ncphillips Date: Tue, 9 Jan 2018 15:58:30 -0400 Subject: [PATCH 1/3] fix typo in error report --- packages/create-typescript-package/createTypescriptPackage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-typescript-package/createTypescriptPackage.js b/packages/create-typescript-package/createTypescriptPackage.js index e6c2be2..487c212 100644 --- a/packages/create-typescript-package/createTypescriptPackage.js +++ b/packages/create-typescript-package/createTypescriptPackage.js @@ -97,7 +97,7 @@ const program = new commander.Command(packageJson.name) ) console.log( ` ${chalk.cyan( - "https://github.com/facebookincubator/create-typescript-package/issues/new" + "https://github.com/ncphillips/create-typescript-package/issues/new" )}` ) console.log() From d3f36c4500249c50d84fa290988f8b8111d6083c Mon Sep 17 00:00:00 2001 From: ncphillips Date: Tue, 9 Jan 2018 16:09:19 -0400 Subject: [PATCH 2/3] log out full error with link to github issues --- packages/type-scripts/scripts/build.js | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/packages/type-scripts/scripts/build.js b/packages/type-scripts/scripts/build.js index 3dcd825..9b38c5e 100644 --- a/packages/type-scripts/scripts/build.js +++ b/packages/type-scripts/scripts/build.js @@ -1,4 +1,5 @@ #! /usr/bin/env node +const chalk = require("chalk") const path = require("path") const rollupTypescript = require("rollup-plugin-typescript2") const rollup = require("rollup") @@ -48,8 +49,20 @@ async function build() { await bundle.write(outputOptions) } -try { - build() -} catch (e) { - console.error("Failed to build Typescript project", e) -} +build().catch(e => { + console.log(chalk.red("Build Failed")) + console.log() + console.log( + chalk.red( + "If you cannot figure out what's causing this failure please create a new issue in Github:" + ) + ) + console.log() + console.log( + `\t${chalk.cyan( + "https://github.com/ncphillips/create-typescript-package/issues/new" + )}` + ) + console.log() + console.error(e) +}) From 491db500b492c72407d99a223627670df1e20618 Mon Sep 17 00:00:00 2001 From: ncphillips Date: Tue, 9 Jan 2018 16:16:37 -0400 Subject: [PATCH 3/3] allow for the import of commonjs modules --- packages/type-scripts/package.json | 1 + packages/type-scripts/scripts/build.js | 4 ++++ packages/type-scripts/yarn.lock | 30 +++++++++++++++++++++++++- 3 files changed, 34 insertions(+), 1 deletion(-) diff --git a/packages/type-scripts/package.json b/packages/type-scripts/package.json index 8c2bb6c..1dc6bdc 100644 --- a/packages/type-scripts/package.json +++ b/packages/type-scripts/package.json @@ -18,6 +18,7 @@ "chalk": "^2.3.0", "react-dev-utils": "^4.2.1", "rollup": "^0.53.3", + "rollup-plugin-commonjs": "^8.2.6", "rollup-plugin-node-resolve": "^3.0.0", "rollup-plugin-typescript2": "^0.9.0" }, diff --git a/packages/type-scripts/scripts/build.js b/packages/type-scripts/scripts/build.js index 9b38c5e..6042815 100644 --- a/packages/type-scripts/scripts/build.js +++ b/packages/type-scripts/scripts/build.js @@ -4,6 +4,7 @@ const path = require("path") const rollupTypescript = require("rollup-plugin-typescript2") const rollup = require("rollup") const resolve = require("rollup-plugin-node-resolve") +const commonJs = require("rollup-plugin-commonjs") const PROJECT = "../../../" const NODE_MODULES = "../../" @@ -30,6 +31,9 @@ const inputOptions = { moduleDirectory: path.resolve(__dirname, NODE_MODULES), }, }), + commonJs({ + sourceMap: true, + }), ], } diff --git a/packages/type-scripts/yarn.lock b/packages/type-scripts/yarn.lock index 8638707..4aaf44a 100644 --- a/packages/type-scripts/yarn.lock +++ b/packages/type-scripts/yarn.lock @@ -2,6 +2,10 @@ # yarn lockfile v1 +acorn@^5.2.1: + version "5.3.0" + resolved "https://registry.yarnpkg.com/acorn/-/acorn-5.3.0.tgz#7446d39459c54fb49a80e6ee6478149b940ec822" + address@1.0.3, address@^1.0.1: version "1.0.3" resolved "https://registry.yarnpkg.com/address/-/address-1.0.3.tgz#b5f50631f8d6cec8bd20c963963afb55e06cbce9" @@ -170,6 +174,10 @@ estree-walker@^0.3.0: version "0.3.1" resolved "https://registry.yarnpkg.com/estree-walker/-/estree-walker-0.3.1.tgz#e6b1a51cf7292524e7237c312e5fe6660c1ce1aa" +estree-walker@^0.5.0: + version "0.5.1" + resolved "https://registry.yarnpkg.com/estree-walker/-/estree-walker-0.5.1.tgz#64fc375053abc6f57d73e9bd2f004644ad3c5854" + esutils@^2.0.2: version "2.0.2" resolved "https://registry.yarnpkg.com/esutils/-/esutils-2.0.2.tgz#0abf4f1caa5bcb1f7a9d8acc6dea4faaa04bac9b" @@ -479,6 +487,12 @@ lru-cache@^4.0.1: pseudomap "^1.0.2" yallist "^2.1.2" +magic-string@^0.22.4: + version "0.22.4" + resolved "https://registry.yarnpkg.com/magic-string/-/magic-string-0.22.4.tgz#31039b4e40366395618c1d6cf8193c53917475ff" + dependencies: + vlq "^0.2.1" + micromatch@^2.3.11: version "2.3.11" resolved "https://registry.yarnpkg.com/micromatch/-/micromatch-2.3.11.tgz#86677c97d1720b363431d04d0d15293bd38c1565" @@ -656,7 +670,7 @@ resolve@1.1.7: version "1.1.7" resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.1.7.tgz#203114d82ad2c5ed9e8e0411b3932875e889e97b" -resolve@^1.1.6, resolve@^1.5.0: +resolve@^1.1.6, resolve@^1.4.0, resolve@^1.5.0: version "1.5.0" resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.5.0.tgz#1f09acce796c9a762579f31b2c1cc4c3cddf9f36" dependencies: @@ -669,6 +683,16 @@ restore-cursor@^2.0.0: onetime "^2.0.0" signal-exit "^3.0.2" +rollup-plugin-commonjs@^8.2.6: + version "8.2.6" + resolved "https://registry.yarnpkg.com/rollup-plugin-commonjs/-/rollup-plugin-commonjs-8.2.6.tgz#27e5b9069ff94005bb01e01bb46a1e4873784677" + dependencies: + acorn "^5.2.1" + estree-walker "^0.5.0" + magic-string "^0.22.4" + resolve "^1.4.0" + rollup-pluginutils "^2.0.1" + rollup-plugin-node-resolve@^3.0.0: version "3.0.0" resolved "https://registry.yarnpkg.com/rollup-plugin-node-resolve/-/rollup-plugin-node-resolve-3.0.0.tgz#8b897c4c3030d5001277b0514b25d2ca09683ee0" @@ -813,6 +837,10 @@ url-parse@^1.1.8: querystringify "~1.0.0" requires-port "~1.0.0" +vlq@^0.2.1: + version "0.2.3" + resolved "https://registry.yarnpkg.com/vlq/-/vlq-0.2.3.tgz#8f3e4328cf63b1540c0d67e1b2778386f8975b26" + websocket-driver@>=0.5.1: version "0.7.0" resolved "https://registry.yarnpkg.com/websocket-driver/-/websocket-driver-0.7.0.tgz#0caf9d2d755d93aee049d4bdd0d3fe2cca2a24eb"