Skip to content

Commit 0067ba2

Browse files
committed
network: fix potential use-after-free
Signed-off-by: Felix Fietkau <[email protected]>
1 parent 8e77d44 commit 0067ba2

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

auth-data.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ int unet_auth_data_validate(const uint8_t *key, const void *buf, size_t len,
3131
if (!edsign_verify(&vst, hdr->signature, data->pubkey))
3232
return -3;
3333

34-
if (*(char *)(data + len - 1) != 0)
34+
if (((char *)data)[len - 1] != 0)
3535
return -2;
3636

3737
if (timestamp)

network.c

+1
Original file line numberDiff line numberDiff line change
@@ -436,6 +436,7 @@ static int network_setup(struct network *net)
436436

437437
static void network_teardown(struct network *net)
438438
{
439+
uloop_timeout_cancel(&net->connect_timer);
439440
uloop_timeout_cancel(&net->reload_timer);
440441
network_do_update(net, false);
441442
network_pex_close(net);

0 commit comments

Comments
 (0)