Skip to content

Commit 03785ae

Browse files
authored
Merge pull request #8 from Azure/master
Rebase
2 parents e2c33e0 + b7a061c commit 03785ae

File tree

2,407 files changed

+305522
-14220
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

2,407 files changed

+305522
-14220
lines changed

.azure-pipelines-preproduction/package-lock.json

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.azure-pipelines-preproduction/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
"ts-node": "^8.1.0",
2626
"tslib": "^1.10.0",
2727
"typescript": "3.5.3",
28-
"prettier": "^1.18.2"
28+
"prettier": "^1.18.2",
29+
"minimist": "^1.2.3"
2930
},
3031
"homepage": "https://github.com/azure/azure-rest-api-specs",
3132
"repository": {
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
schedules:
2+
- cron: "0 0 * * *"
3+
displayName: Daily build
4+
branches:
5+
include:
6+
- master
7+
always: true
8+
9+
pool:
10+
vmImage: 'Ubuntu-16.04'
11+
12+
variables:
13+
IMAGE_TAG_PREFIX: $[format('1.0.{0:HHm}', pipeline.startTime)]
14+
15+
steps:
16+
- task: Docker@2
17+
displayName: Login to production ACR
18+
inputs:
19+
command: login
20+
containerRegistry: $(CONTAINER_REGISTRY_SERVICE_CONNECTION)
21+
22+
- task: Docker@2
23+
displayName: Login to dogfood ACR
24+
inputs:
25+
command: login
26+
containerRegistry: $(DOGFOOD_CONTAINER_REGISTRY_SERVICE_CONNECTION)
27+
28+
- task: CopyFiles@2
29+
inputs:
30+
SourceFolder: $(Build.SourcesDirectory)
31+
contents: .git/**
32+
targetFolder: $(Build.SourcesDirectory)/scripts/datacontainer
33+
34+
- task: Docker@2
35+
displayName: Build and Push
36+
inputs:
37+
command: buildAndPush
38+
Dockerfile: scripts/datacontainer/Dockerfile
39+
repository: $(CONTAINER_REGISTRY_REPOSITORY_NAME)
40+
tags: |
41+
latest
42+
$(IMAGE_TAG_PREFIX)$(Build.BuildNumber)

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,27 @@
22
</i>
33

44
### Contribution checklist:
5+
- [ ] I commit to follow the [Breaking Change Policy](http://aka.ms/bcforapi) of “no breaking changes
56
- [ ] I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow.
6-
- [ ] [Validation tools](https://aka.ms/swaggertools) were run on swagger spec(s) and have all been fixed in this PR. [How to fix?](https://aka.ms/ci-fix)
7+
- [ ] [Validation tools](https://aka.ms/swaggertools) were run on swagger spec(s) and errors have all been fixed in this PR. [How to fix?](https://aka.ms/ci-fix)
78

89
If any further question about AME onboarding or validation tools, please view the [FAQ](https://aka.ms/faqinprreview).
910

1011
### ARM API Review Checklist
11-
- [ ] Service team MUST add the "**WaitForARMFeedback**" label if the management plane API changes fall into one of the below categories.
12-
- adding/removing APIs.
13-
- adding/removing properties.
14-
- adding/removing API-version.
15-
- adding a new service in Azure.
12+
- [ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
13+
- Adding new API(s)
14+
- Adding a new API version
15+
- Adding a new service
1616

17-
<i>Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.</i>
17+
- [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (*RP Manifest Approvers* team under <ins>Azure Resource Manager service</ins>) from IcM and reach out to them.
1818

19-
- [ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
20-
Please follow the link to find more details on [API review process](https://aka.ms/SwaggerPRReview).
19+
### Breaking Change Review Checklist
20+
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the [Breaking Change Policy](http://aka.ms/bcforapi).
21+
22+
- [ ] Removing API(s) in stable version
23+
- [ ] Removing properties in stable version
24+
- [ ] Removing API version(s) in stable version
25+
- [ ] Updating API in stable version with Breaking Change Validation errors
26+
- [ ] Updating API(s) in preview over 1 year
27+
28+
Please follow the link to find more details on [PR review process](https://aka.ms/SwaggerPRReview).

.github/assignment.yml

Lines changed: 0 additions & 154 deletions
This file was deleted.

.github/issue_assignment.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
booleanFilterExpression: "needs-triage"
44
assignees:
55
- yungezz
6-
- zikalino
76
- erich-wang
87
- NullMDR
98
- raych1

.github/pull_request_assignment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@
9696
- rule:
9797
paths:
9898
- "specification/mixedreality/**"
99+
- "specification/hdinsight/**"
99100
reviewers:
100101
- leni-msft
101102

@@ -136,7 +137,6 @@
136137
- "**"
137138
reviewers:
138139
- yungezz
139-
- zikalino
140140
- erich-wang
141141
- NullMDR
142142
- raych1

.github/reviewer.yml

Lines changed: 0 additions & 13 deletions
This file was deleted.

.github/sla.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,3 +84,18 @@
8484
subject: "Action Required: Please respond to issue ${URL}"
8585
to: ${ASSIGNEE}
8686
87+
88+
- scheduleTask:
89+
action: sendEmail
90+
scope: pull_request
91+
name: "send email given path change"
92+
trigger:
93+
- path
94+
args:
95+
message: '<p>You have just completed the first step towards onboarding your API change to the Compute Management library.</p><p>We (<a href="mailto:[email protected]">the CPlatSDK/PowerShell team</a>) manage the Compute library&#39;s API and SDK for the following clients: Swagger (REST api), .NET SDK, and Azure PowerShell.</p><p>You&#39;ve just opened a PR making changes in the Compute Management Library&#39;s path of the Azure REST Api Specs repository.</p><p>What&#39;s next?</p><ol type="1"><li value="1">Your api specs need to be reviewed and approved by us and the ARM team</li><li>Make sure you that can generate the .NET SDK from your API specs using the Autorest tool (<a href="https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/73168/SDK-(.NET)?anchor=how-to-generate-the-sdk%3F">NET SDK autogeneration</a>)</li><li>While your specs are getting reviewed, you should be working on the .NET SDK. (<a href="https://github.com/Azure/azure-sdk-for-net/">SDK repo</a>)</li><ol type="a"><li value="1">Once you generate the .NET SDK, you need to create the SDK tests and perform recordings and playbacks. (<a href="https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/73168/SDK-(.NET)?anchor=how-to-set-up-testing-and-record-tests%3F">NET SDK testing</a>)</li><li>With the newly generated SDK with tests, you can make a pull request to the SDK repository.<br /> Make sure to add a reference to your Swagger pull request in the comments.</li></ol><li>[If applicable] At this stage, you can get started on the Azure PowerShell part.<ol type="a"><li value="1">All you need to do is send a design doc of any change/new Azure PowerShell cmdlet related to your api by creating an issue with your design <a href="https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues">here</a>.<br>Then, send an email to <a href="mailto:[email protected]">[email protected]</a> with the issue number and cc our dl (<a href="mailto:[email protected]">[email protected]</a>) on the email, so we can leave comments on your design doc as well.</li><li>Once your PowerShell cmdlet design has been approved, send an email to&nbsp;<a href="mailto:[email protected]?subject=PowerShell%20Design%20Review%20Approved">our team</a><br /> We will implement and test the PowerShell cmdlet following the approved design. We will then make a pull request to the appropriate repository</li></ol><li>[If applicable] You can also get started on any Azure CLI module or extension for your API change. Find more information about next steps on that process <a href="https://github.com/Azure/azure-cli/blob/dev/doc/onboarding_guide.md">here</a>.</li></ol><hr><ul type="disc"><li>To view the full CPlat SDK PowerShell API onboarding wiki, please visit <a href="https://aka.ms/cplatsdk">aka.ms/cplatsdk</a></li></ul><p>This email was automatically sent. Please send an email to&nbsp;<a href="mailto:[email protected]">[email protected]</a>&nbsp;if you have any questions.</p>'
96+
targetPaths:
97+
- "specification/compute/resource-manager/Microsoft.Compute/**"
98+
subject: "[Action Required] CPlat Swagger Pull Request opened: Next steps"
99+
to: ${AUTHOR}
100+
cc:
101+

CODEOWNERS

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
/specification/cognitiveservices/ @felixwa @yangyuan
1313
/specification/compute/ @hyonholee @mabhard @danielli90 @smotwani @ppatwa @vikramd-ms @savyasachisamal @yunusm @ZhidongPeng @nkuchta @maheshnemichand @najams @changov
1414
/specification/consumption/ @kjeur @panda-wang
15-
/specification/containerinstance/ @samkreter
15+
/specification/containerinstance/ @novinc
1616
/specification/containerregistry/ @djyou
1717
/specification/containerservice/ @yangl900
18-
/specification/cosmos-db/ @dmakwana
18+
/specification/cosmos-db/ @dmakwana @MehaKaushik @wmengmsft @shurd
1919
/specification/customer-insights/ @tjlvtao
2020
/specification/datafactory/ @zhangyd2015
2121
/specification/datalake-analytics/ @ro-joowan
@@ -74,5 +74,5 @@
7474
/specification/subscriptions/ @navysingla
7575
/specification/timeseriesinsights/ @sandshadow
7676
/specification/trafficmanager/ @allencal @hrkulkarmsft
77-
/specification/web/ @lukaszstem @naveedaz @nking92
77+
/specification/web/ @naveedaz @Azure/azure-app-service-control-plane
7878
/profile/ @shahabhijeet

0 commit comments

Comments
 (0)