Merge pull request #8 from Azure/master

Rebase

Author: navysingla

.azure-pipelines-preproduction/package-lock.json

@@ -25,7 +25,8 @@
     "ts-node": "^8.1.0",
     "tslib": "^1.10.0",
     "typescript": "3.5.3",
-    "prettier": "^1.18.2"
+    "prettier": "^1.18.2",
+    "minimist": "^1.2.3"
   },
   "homepage": "https://github.com/azure/azure-rest-api-specs",
   "repository": {

.azure-pipelines-preproduction/package.json

@@ -0,0 +1,42 @@
+schedules:
+- cron: "0 0 * * *"
+  displayName: Daily build
+  branches:
+    include:
+    - master
+  always: true
+
+pool:
+  vmImage: 'Ubuntu-16.04'
+
+variables:
+  IMAGE_TAG_PREFIX: $[format('1.0.{0:HHm}', pipeline.startTime)]
+
+steps:
+- task: Docker@2
+  displayName: Login to production ACR
+  inputs:
+    command: login
+    containerRegistry: $(CONTAINER_REGISTRY_SERVICE_CONNECTION)
+
+- task: Docker@2
+  displayName: Login to dogfood ACR
+  inputs:
+    command: login
+    containerRegistry: $(DOGFOOD_CONTAINER_REGISTRY_SERVICE_CONNECTION)
+
+- task: CopyFiles@2
+  inputs:
+    SourceFolder: $(Build.SourcesDirectory)
+    contents: .git/**
+    targetFolder: $(Build.SourcesDirectory)/scripts/datacontainer
+
+- task: Docker@2
+  displayName: Build and Push
+  inputs:
+    command: buildAndPush
+    Dockerfile: scripts/datacontainer/Dockerfile
+    repository: $(CONTAINER_REGISTRY_REPOSITORY_NAME)
+    tags: |
+      latest
+      $(IMAGE_TAG_PREFIX)$(Build.BuildNumber)

.azure-pipelines/azure-pipelines-data-container.yml

@@ -2,19 +2,27 @@
 </i>
 
 ### Contribution checklist:
+- [ ] I commit to follow the [Breaking Change Policy](http://aka.ms/bcforapi) of “no breaking changes
 - [ ] I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow.
-- [ ] [Validation tools](https://aka.ms/swaggertools) were run on swagger spec(s) and have all been fixed in this PR. [How to fix?](https://aka.ms/ci-fix)
+- [ ] [Validation tools](https://aka.ms/swaggertools) were run on swagger spec(s) and errors have all been fixed in this PR. [How to fix?](https://aka.ms/ci-fix)
 
 If any further question about AME onboarding or validation tools, please view the [FAQ](https://aka.ms/faqinprreview).
 
 ### ARM API Review Checklist
-- [ ] Service team MUST add the "**WaitForARMFeedback**" label if the management plane API changes fall into one of the below categories. 
-  - adding/removing APIs.
-  - adding/removing properties.
-  - adding/removing API-version. 
-  - adding a new service in Azure.
+- [ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
+  - Adding new API(s)
+  - Adding a new API version
+  - Adding a new service
 
-<i>Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.</i>
+- [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (*RP Manifest Approvers* team under <ins>Azure Resource Manager service</ins>) from IcM and reach out to them. 
 
-- [ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them. 
-Please follow the link to find more details on [API review process](https://aka.ms/SwaggerPRReview).
+### Breaking Change Review Checklist 
+If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the [Breaking Change Policy](http://aka.ms/bcforapi). 
+
+- [ ] Removing API(s) in stable version
+- [ ] Removing properties in stable version
+- [ ] Removing API version(s) in stable version
+- [ ] Updating API in stable version with Breaking Change Validation errors
+- [ ] Updating API(s) in preview over 1 year
+
+Please follow the link to find more details on [PR review process](https://aka.ms/SwaggerPRReview).

.github/PULL_REQUEST_TEMPLATE.md

@@ -3,7 +3,6 @@
     booleanFilterExpression: "needs-triage"
     assignees:
       - yungezz
-      - zikalino
       - erich-wang
       - NullMDR
       - raych1

.github/assignment.yml

@@ -96,6 +96,7 @@
 - rule:
     paths:
       - "specification/mixedreality/**"
+      - "specification/hdinsight/**"
     reviewers:
       - leni-msft
 
@@ -136,7 +137,6 @@
       - "**"
     reviewers:
       - yungezz
-      - zikalino
       - erich-wang
       - NullMDR
       - raych1

.github/issue_assignment.yml

@@ -84,3 +84,18 @@
       subject: "Action Required: Please respond to issue ${URL}"
       to: ${ASSIGNEE}
       cc: [email protected]
+
+- scheduleTask:	
+    action: sendEmail	
+    scope: pull_request	
+    name: "send email given path change"	
+    trigger:	
+      - path	
+    args:	
+      message: '<p>You have just completed the first step towards onboarding your API change to the Compute Management library.</p><p>We (<a href="mailto:[email protected]">the CPlatSDK/PowerShell team</a>) manage the Compute library&#39;s API and SDK for the following clients: Swagger (REST api), .NET SDK, and Azure PowerShell.</p><p>You&#39;ve just opened a PR making changes in the Compute Management Library&#39;s path of the Azure REST Api Specs repository.</p><p>What&#39;s next?</p><ol type="1"><li value="1">Your api specs need to be reviewed and approved by us and the ARM team</li><li>Make sure you that can generate the .NET SDK from your API specs using the Autorest tool (<a href="https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/73168/SDK-(.NET)?anchor=how-to-generate-the-sdk%3F">NET SDK autogeneration</a>)</li><li>While your specs are getting reviewed, you should be working on the .NET SDK. (<a href="https://github.com/Azure/azure-sdk-for-net/">SDK repo</a>)</li><ol type="a"><li value="1">Once you generate the .NET SDK, you need to create the SDK tests and perform recordings and playbacks. (<a href="https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/73168/SDK-(.NET)?anchor=how-to-set-up-testing-and-record-tests%3F">NET SDK testing</a>)</li><li>With the newly generated SDK with tests, you can make a pull request to the SDK repository.<br /> Make sure to add a reference to your Swagger pull request in the comments.</li></ol><li>[If applicable] At this stage, you can get started on the Azure PowerShell part.<ol type="a"><li value="1">All you need to do is send a design doc of any change/new Azure PowerShell cmdlet related to your api by creating an issue with your design <a href="https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues">here</a>.<br>Then, send an email to <a href="mailto:[email protected]">[email protected]</a> with the issue number and cc our dl (<a href="mailto:[email protected]">[email protected]</a>) on the email, so we can leave comments on your design doc as well.</li><li>Once your PowerShell cmdlet design has been approved, send an email to&nbsp;<a href="mailto:[email protected]?subject=PowerShell%20Design%20Review%20Approved">our team</a><br /> We will implement and test the PowerShell cmdlet following the approved design. We will then make a pull request to the appropriate repository</li></ol><li>[If applicable] You can also get started on any Azure CLI module or extension for your API change. Find more information about next steps on that process <a href="https://github.com/Azure/azure-cli/blob/dev/doc/onboarding_guide.md">here</a>.</li></ol><hr><ul type="disc"><li>To view the full CPlat SDK PowerShell API onboarding wiki, please visit <a href="https://aka.ms/cplatsdk">aka.ms/cplatsdk</a></li></ul><p>This email was automatically sent. Please send an email to&nbsp;<a href="mailto:[email protected]">[email protected]</a>&nbsp;if you have any questions.</p>'	
+      targetPaths:	
+        - "specification/compute/resource-manager/Microsoft.Compute/**"	
+      subject: "[Action Required] CPlat Swagger Pull Request opened: Next steps"	
+      to: ${AUTHOR}
+      cc:
+        - [email protected]

.github/pull_request_assignment.yml

@@ -12,10 +12,10 @@
 /specification/cognitiveservices/ @felixwa @yangyuan
 /specification/compute/ @hyonholee @mabhard @danielli90 @smotwani @ppatwa @vikramd-ms @savyasachisamal @yunusm @ZhidongPeng @nkuchta @maheshnemichand @najams @changov
 /specification/consumption/ @kjeur @panda-wang
-/specification/containerinstance/ @samkreter
+/specification/containerinstance/ @novinc
 /specification/containerregistry/ @djyou
 /specification/containerservice/ @yangl900
-/specification/cosmos-db/ @dmakwana
+/specification/cosmos-db/ @dmakwana @MehaKaushik @wmengmsft @shurd
 /specification/customer-insights/ @tjlvtao
 /specification/datafactory/ @zhangyd2015
 /specification/datalake-analytics/ @ro-joowan
@@ -74,5 +74,5 @@
 /specification/subscriptions/ @navysingla
 /specification/timeseriesinsights/ @sandshadow
 /specification/trafficmanager/ @allencal @hrkulkarmsft
-/specification/web/ @lukaszstem @naveedaz @nking92
+/specification/web/ @naveedaz @Azure/azure-app-service-control-plane
 /profile/ @shahabhijeet