Add sanitizations and validations

Author: yeraydavidrodriguez

__tests__/unit/git-repo-dir.test.ts

@@ -1,4 +1,6 @@
+import {GitDirNotExistsError} from '../../src/errors'
 import {GitRepoDir} from '../../src/git-repo-dir'
+import {createInexistentTempDir} from '../../src/__tests__/helpers'
 
 describe('GitRepoDir', () => {
   it('should contain dir path for the Git repo', () => {
@@ -7,6 +9,13 @@ describe('GitRepoDir', () => {
     expect(gitRepoDir.getDirPath()).toBe('./')
   })
 
+  it('should throw on a non-existent Dir initialization', async () => {
+    const inexistentDir = await createInexistentTempDir()
+    const failingRepoDirTest = (): GitRepoDir => new GitRepoDir(inexistentDir)
+
+    expect(failingRepoDirTest).toThrow(GitDirNotExistsError)
+  })
+
   it('should compare two git repo dirs', () => {
     const gitRepoDir1 = new GitRepoDir('./')
     const gitRepoDir2 = new GitRepoDir('../')

src/__tests__/helpers.ts

@@ -9,13 +9,18 @@ import {GitRepo} from '../git-repo'
 import {GitRepoDir} from '../git-repo-dir'
 
 import {createTempDir} from 'jest-fixtures'
+import {join} from 'path'
 import {testConfiguration} from './config'
 
 export async function createTempEmptyDir(): Promise<string> {
   const tempGitDirPath = await createTempDir()
   return tempGitDirPath
 }
 
+export async function createInexistentTempDir(): Promise<string> {
+  return join(await createTempEmptyDir(), `inexistent`)
+}
+
 export async function createInitializedTempGnuPGHomeDir(): Promise<string> {
   const tempGnuPGHomeDir = await createTempDir()
   const keygrip = testConfiguration().gpg_signing_key.keygrip

src/errors.ts

@@ -37,6 +37,13 @@ export class GitDirNotInitializedError extends Error {
   }
 }
 
+export class GitDirNotExistsError extends Error {
+  constructor(dir: string) {
+    super(`Git dir: ${dir} does not exist or is not reachable`)
+    Object.setPrototypeOf(this, GitDirNotExistsError.prototype)
+  }
+}
+
 export class PendingJobsLimitReachedError extends Error {
   constructor(committedMessage: CommittedMessage) {
     super(

src/git-repo-dir.ts

@@ -1,8 +1,13 @@
+import {GitDirNotExistsError} from './errors'
+import {existsSync} from 'fs'
+
 export class GitRepoDir {
   private readonly dirPath: string
 
   constructor(dirPath: string) {
-    // TODO: validate dir path
+    if (!existsSync(dirPath)) {
+      throw new GitDirNotExistsError(dirPath)
+    }
     this.dirPath = dirPath
   }
 

src/git-repo.ts

@@ -17,8 +17,9 @@ export class GitRepo {
 
   isInitialized(): boolean {
     try {
-      if (!this.dirPathExists()) {
-        return false
+      // Make sure the string we will pass to to the shell is an actual dir
+      if (!existsSync(this.dir.getDirPath())) {
+        throw new Error()
       }
       execSync(`cd ${this.getDirPath()} && git status`)
     } catch {
@@ -35,10 +36,6 @@ export class GitRepo {
     return this.dir.getDirPath()
   }
 
-  dirPathExists(): boolean {
-    return existsSync(this.getDirPath())
-  }
-
   async init(): Promise<void> {
     await this.git.init()
   }
@@ -61,6 +58,10 @@ export class GitRepo {
       throw new GitDirNotInitializedError(this.dir.getDirPath())
     }
     try {
+      // Make sure the string we will pass to to the shell is an actual dir
+      if (!existsSync(this.dir.getDirPath())) {
+        throw new Error()
+      }
       execSync(`cd ${this.dir.getDirPath()} && git log -n 0`)
     } catch (err) {
       // No commits yet