From 8a54203337e8b12e3640b882a98d9e20b947ccbf Mon Sep 17 00:00:00 2001 From: Matt Funnell Date: Sat, 8 Mar 2025 05:35:03 +0000 Subject: [PATCH 1/4] Make the parameter-less StreamConfig constructor public --- src/NATS.Client.JetStream/Models/StreamConfig.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/NATS.Client.JetStream/Models/StreamConfig.cs b/src/NATS.Client.JetStream/Models/StreamConfig.cs index fdacdaf30..12f937393 100644 --- a/src/NATS.Client.JetStream/Models/StreamConfig.cs +++ b/src/NATS.Client.JetStream/Models/StreamConfig.cs @@ -10,7 +10,7 @@ public StreamConfig(string name, ICollection subjects) Subjects = subjects; } - internal StreamConfig() + public StreamConfig() { } From 2050c17236e59407bb5cf32becebdc0806abd1fd Mon Sep 17 00:00:00 2001 From: Matt Funnell Date: Thu, 10 Apr 2025 05:36:09 +0100 Subject: [PATCH 2/4] Make NatsMsg.Build Public --- src/NATS.Client.Core/NatsMsg.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/NATS.Client.Core/NatsMsg.cs b/src/NATS.Client.Core/NatsMsg.cs index 8c7541dde..e1e48f710 100644 --- a/src/NATS.Client.Core/NatsMsg.cs +++ b/src/NATS.Client.Core/NatsMsg.cs @@ -311,7 +311,7 @@ public void Deconstruct(out string subject, out string? replyTo, out int size, o flags = Flags; } - internal static NatsMsg Build( + public static NatsMsg Build( string subject, string? replyTo, in ReadOnlySequence? headersBuffer, From 134042d83b0c64ec16e3159ef2c31746b704ac0d Mon Sep 17 00:00:00 2001 From: Ziya Suzen Date: Thu, 10 Apr 2025 11:25:17 +0100 Subject: [PATCH 3/4] Add docs --- src/NATS.Client.Core/NatsMsg.cs | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/NATS.Client.Core/NatsMsg.cs b/src/NATS.Client.Core/NatsMsg.cs index e1e48f710..a2af93bd8 100644 --- a/src/NATS.Client.Core/NatsMsg.cs +++ b/src/NATS.Client.Core/NatsMsg.cs @@ -311,6 +311,22 @@ public void Deconstruct(out string subject, out string? replyTo, out int size, o flags = Flags; } + /// + /// Builds a new instance of a with the specified parameters. + /// + /// + /// (LOW LEVEL API) This method is intended for internal use only. it doesn't have the same + /// guarantees as the public API. it may change in future versions with no notice. + /// + /// The subject string associated with the message. + /// The optional reply-to subject string. + /// The optional buffer containing the message headers. + /// The buffer containing the message payload. + /// The connection associated with the message. + /// The parser for processing message headers. + /// The deserializer for the message payload. + /// A new instance containing the provided data. + /// Thrown if there is an error during the processing of the message. public static NatsMsg Build( string subject, string? replyTo, From f0fdb45ac646528262f90b19baf3937a00198b0e Mon Sep 17 00:00:00 2001 From: Ziya Suzen Date: Thu, 10 Apr 2025 11:34:48 +0100 Subject: [PATCH 4/4] Add docs [no ci] --- src/NATS.Client.Core/NatsMsg.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/NATS.Client.Core/NatsMsg.cs b/src/NATS.Client.Core/NatsMsg.cs index a2af93bd8..ea9c1d0c7 100644 --- a/src/NATS.Client.Core/NatsMsg.cs +++ b/src/NATS.Client.Core/NatsMsg.cs @@ -315,7 +315,7 @@ public void Deconstruct(out string subject, out string? replyTo, out int size, o /// Builds a new instance of a with the specified parameters. /// /// - /// (LOW LEVEL API) This method is intended for internal use only. it doesn't have the same + /// (INTERNAL API) This method is intended for internal use only. it doesn't have the same /// guarantees as the public API. it may change in future versions with no notice. /// /// The subject string associated with the message.