[CHORE] externalize version reported by the client to a JSON file

Author: aricart

Diff for: transport-node/bin/check-bundle-version.ts

@@ -1,5 +1,5 @@
 /*
- * Copyright 2021 The NATS Authors
+ * Copyright 2021-2024 The NATS Authors
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -12,33 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-const src = await Deno.readTextFile("src/node_transport.ts");
-const lines = src.split("\n");
-const filtered = lines.filter((txt) => {
-  return txt.indexOf("const VERSION") === 0;
-});
-let parsed = filtered.map((line) => {
-  const chunks = line.split(" ");
-  if (
-    chunks.length === 4 &&
-    chunks[0] === "const" &&
-    chunks[1] === "VERSION" &&
-    chunks[2] === "="
-  ) {
-    let v = chunks[3].replace(";", "");
-    v = JSON.parse(v);
-    return v;
-  }
-});
-parsed = parsed ?? [];
-if (parsed.length !== 1) {
-  console.error(`[ERROR] unexpected number of matches on 'const VERSION'.`);
-  Deno.exit(1);
-}
-let VERSION = "";
-if (parsed.length === 1) {
-  VERSION = parsed[0] ?? "";
-}
+const { VERSION } = JSON.parse(await Deno.readTextFile("src/version.json"));
 
 const pkg = await Deno.readTextFile("package.json");
 const m = JSON.parse(pkg);

Diff for: transport-node/src/node_transport.ts

@@ -33,8 +33,8 @@ import { connect as tlsConnect, TlsOptions, TLSSocket } from "tls";
 const { resolve } = require("path");
 const { readFile, existsSync } = require("fs");
 const dns = require("dns");
-
-const VERSION = "2.26.0";
+const data = require("./version.json");
+export const VERSION = data.version;
 const LANG = "nats.js";
 
 export class NodeTransport implements Transport {

Diff for: transport-node/src/version.json

@@ -0,0 +1,3 @@
+{
+  "version": "3.0.0-1"
+}

Diff for: transport-node/tests/basics_test.js

@@ -23,6 +23,10 @@ const {
   "../lib/mod",
 );
 
+const {
+  VERSION,
+} = require("../lib/node_transport");
+
 const { Lock } = require("./helpers/lock");
 const { NatsServer } = require("./helpers/launcher");
 const { jetstreamServerConf } = require("./helpers/jsutil.js");
@@ -33,9 +37,13 @@ describe(
   "basics",
   { timeout: 20_000, concurrency: true, forceExit: true },
   () => {
+    it("basics - reported version", async () => {
+      const pkg = require("../package.json");
+      assert.equal(VERSION, pkg.version);
+    });
     it("basics - connect default", async () => {
       const ns = await NatsServer.start({ port: 4222 });
-      const nc = await connect();
+      const nc = await connect({ debug: true });
       await nc.flush();
       await nc.close();
       await ns.stop();

Diff for: transport-node/tsconfig.json

@@ -7,10 +7,11 @@
     "sourceMap": true,
     "declaration": true,
     "allowJs": true,
-    "removeComments": false
+    "removeComments": false,
+    "resolveJsonModule": true
   },
   "include": [
-    "src"
+    "src/**/*"
   ],
   "exclude": [
     "transport-node/test/**/*",