Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch worker per environment settings #640

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

anfeng
Copy link
Collaborator

@anfeng anfeng commented Aug 1, 2013

To launch storm workers in a cloud environment, we need to handle some minor issues:

  • worker's logs have to be located in certain directory (instead of current working directory)
  • logback configuration file is located in a distributed file system directory (instead of current working directory)
  • JAVA_HOME needs to respected if it's specified in an environment

This pull request makes the following challenges to supervisor's logic to launch workers:

  • If JAVA_HOME is specified in an environment, we will use <JAVA_HOME>/bin/java
  • If "worker.logdir" is specified in supervisor's command (-Dworker.logdir=xxxx), worker logs will be stored in that directory
  • worker's logback configuration file will be identical to supervisor's logback configuration.

anfeng added 3 commits July 31, 2013 15:45
merge changes from nathanmarz/storm master
merge changes from nathanmarz/storm master
java_home (System/getenv "JAVA_HOME")
java_cmd (if java_home (str java_home "/bin/java") "java")
worker_logdir (System/getProperty "worker.logdir")
logfilename (str (if worker_logdir (str worker_logdir "/") "") "worker-" port ".log")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be good to use the File/separator instead of "/" while we are changing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants