Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogue balloon panel rendering scene (or sprites) inside itself #628

Closed
mihailides opened this issue Jul 22, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@mihailides
Copy link

Describe the bug
The dialogue balloon is rendering a sprite that I have inside the same scene. (I can see the sprite in the background, and once the balloon appears, it renders inside of that as well). Debug printing inside of the sprite seems that it only loads once.

Affected version

  • Dialogue Manager version:
    v2.41.3
  • Godot version:
    4.2

To Reproduce
Steps to reproduce the behavior:

(Basically straight out of the tutorial)

  1. Create a scene with a Node2D
  2. Attach one child - a Sprite2D and add a resource
  3. Add a script to the root node, the sprite, or to another node2d as a child
  4. Create the balloon programmatically inside _unhandled_input (e.g. DialogueManager.show_dialogue_balloon(dialogue_resource, "start")
  5. Add a custom balloon via project -> tools -> create copy of dialogue example balloon..
  6. Click on Balloon.tscn -> Balloon control node -> open the theme
  7. In the default preview, change type to panel and select the StyleBoxFlat theme
  8. Reduce opacity
  9. Run and notice sprite has rendered into the panel

Expected behavior
Not to have a sprite rendered inside the panel, not sure if I've missed some kind of vital step but I made a whole project from scratch with just these steps to check and had the same issue. It does this with all sprites I add to the scene.

Screenshots
image
image

@mihailides mihailides added the bug Something isn't working label Jul 22, 2024
@Selenyhr
Copy link
Contributor

I've had the same thing with the Vulkan mobile renderer due to this Godot bug.

Since the Panel for the example balloon is also using Clip + Draw, it will trigger this behavior for Godot 4. This seems to have been resolved for Godot 4.3. Meanwhile, changing the renderer to Forward+ solves the issue for current 4.X :)

@nathanhoad
Copy link
Owner

Closing this as it's not technically a bug in Dialogue Manager itself.

@mihailides
Copy link
Author

I've had the same thing with the Vulkan mobile renderer due to this Godot bug.

Since the Panel for the example balloon is also using Clip + Draw, it will trigger this behavior for Godot 4. This seems to have been resolved for Godot 4.3. Meanwhile, changing the renderer to Forward+ solves the issue for current 4.X :)

Thankyou for this, you're amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants