Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'node-proxy' an optionalDependency #40

Closed
natevw opened this issue Dec 11, 2013 · 4 comments
Closed

Make 'node-proxy' an optionalDependency #40

natevw opened this issue Dec 11, 2013 · 4 comments

Comments

@natevw
Copy link
Owner

natevw commented Dec 11, 2013

That way users can decide whether to stick to parentheses, start their app with the right V8 flags, or require it themselves.

This would also facilitate use on certain platforms that offer the standard modules of node.js but are not actually powered by V8.

@mik01aj
Copy link

mik01aj commented Feb 17, 2015

+1. Plus, requiring node-proxy breaks the build for those using browserify.

@natevw
Copy link
Owner Author

natevw commented Feb 17, 2015

I've actually got this in place on a somewhat-unstable "upcoming" branch (npm install git://github.com/natevw/fermata.git#upcoming or use …fermata.git#<current_hash> for stability) if you want to give it a shot. (The main instability on that branch would be around the new streaming response type and how it will be exposed.)

It's tempting to move it even further to something like peerDependencies [although I think that's something different?] or just document it as an optional "install it yourself" — I'm guessing it won't be long before v8 provides Proxy object itself by default (if not already in io.js) and due to its still pending in-browser status I find I don't really use the dot syntax anyway so it's just extra time spent building every deploy…

@laktak
Copy link

laktak commented Aug 10, 2015

+1

@natevw
Copy link
Owner Author

natevw commented Sep 22, 2016

This is done in [email protected], specifically 173def0

@natevw natevw closed this as completed Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants