Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Workbook.write to Uncode filename cause things to broken, if write to http response object. #196

Closed
NStal opened this issue May 29, 2018 · 1 comment
Closed

Workbook.write to Uncode filename cause things to broken, if write to http response object. #196

NStal opened this issue May 29, 2018 · 1 comment
Labels
release/1.4.0

Comments

@NStal
Copy link

NStal commented May 29, 2018

excel4node/source/lib/workbook/workbook.js

Line 165 in f2032ac

'Content-Disposition': 'attachment; filename="' + fileName + '"'

Should encode the filename with EncodeURIComponent.
@NStal NStal changed the title UncodeFilename cause things to broken. Workbook.write to Uncode filename cause things to broken, if write to http response object. May 29, 2018
@natergj
Copy link
Owner

natergj commented Jul 7, 2018

This should now be resolved in version 1.4.0. Thanks, @NStal, for bringing it to my attention.

@natergj natergj closed this as completed Jul 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
release/1.4.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NStal @natergj