Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Add typings.d.ts for use with TypeScript #188

Open
kykint opened this issue Mar 27, 2018 · 5 comments
Open

Add typings.d.ts for use with TypeScript #188

kykint opened this issue Mar 27, 2018 · 5 comments

Comments

@kykint
Copy link

kykint commented Mar 27, 2018

Please, add typings.d.ts for use with TypeScript

@Dominic-Preap
Copy link

Dominic-Preap commented Mar 28, 2018

@natergj and @kykint checkout my repo. I end up customize my own definition. Everything is related to the doc except addConditionalFormattingRule() and addImage() which I am not implement yet.

maybe you guys can help implement and publish it.

@natergj
Copy link
Owner

natergj commented Apr 9, 2018

Thanks, @Dominic-Preap
I've got a branch going right now for version 2 of excel4node. That version is being written in TypeScript and will have types build automatically for it. In the meantime, maybe you could submit your typings file for version 1 to the https://github.com/DefinitelyTyped/DefinitelyTyped repo for other v1 users

@Dominic-Preap
Copy link

@natergj please do it for me cause I am not familiar with publish to npm. It would benefit to everyone. Thank you.

@RyanSMurphyDMCo
Copy link

@natergj How is that second branch coming along for typescript?

@bobweil
Copy link

bobweil commented Oct 23, 2019

For my copy, I added the middle line in the snippet below to cover writing to the Express Response:
write(filename: string): void;
write(filename: string, res: Response): void; // Added this.
write(filename: string, callback: (err: any, stats: Stats) => void): void;

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants