fix: errant slice for trailing whitespace (#28)

chelkyl · web-flow · commit 689c8194752e · 2024-05-02T12:24:05.000-05:00
diff --git a/.changeset/selfish-radios-talk.md b/.changeset/selfish-radios-talk.md
@@ -0,0 +1,5 @@
+---
+"astro-remote": patch
+---
+
+Fixes an issue with internal `getIndent` function used for spacing corrections for `Markdown`
diff --git a/packages/astro-remote/lib/utils.ts b/packages/astro-remote/lib/utils.ts
@@ -39,8 +39,8 @@ export function createComponentProxy(
 }
 
 function getIndent(ln: string): string {
-	if (ln.trim() === ln) return "";
-	return ln.slice(0, ln.length - ln.trim().length);
+	if (ln.trimStart() === ln) return "";
+	return ln.slice(0, ln.length - ln.trimStart().length);
 }
 
 export function dedent(str: string): string {
diff --git a/packages/playground/src/pages/index.astro b/packages/playground/src/pages/index.astro
@@ -14,11 +14,12 @@
 		<ul>
 			<li><a href="/test-md-local">Test Local Markdown "< Markdown >"</a></li>
 			<li><a href="/test-issue7">Test Issue #7</a></li>
+			<li><a href="/test-issue27">Test Issue #27</a></li>
 		</ul>
 	  <h2>Remote:</h2>
 		<ul>
 			<li><a href="/test-html">Test Remote HTML "< Markup >"</a></li>
 			<li><a href="/test-md-remote">Test Remote Markdown "< Markdown >"</a></li>
 		</ul>
   </body>
-</html>
+</html>
diff --git a/packages/playground/src/pages/test-issue27.astro b/packages/playground/src/pages/test-issue27.astro
@@ -0,0 +1,18 @@
+---
+import { Markdown } from "astro-remote";
+---
+
+<html lang="en">
+	<head>
+		<meta charset="utf-8" />
+		<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
+		<meta name="viewport" content="width=device-width" />
+		<meta name="generator" content={Astro.generator} />
+		<title>Astro</title>
+	</head>
+	<body>
+		<Markdown content={"<mark>Highlighted word</mark> with no trailing space"} />
+		<Markdown content={"<mark>Highlighted word</mark> with trailing space "} />
+		<Markdown content={"Non-initial <mark>Highlighted word</mark> with trailing spaces   "} />
+	</body>
+</html>

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,8 @@ export function createComponentProxy(`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`function getIndent(ln: string): string {`
`42`		`- if (ln.trim() === ln) return "";`
`43`		`- return ln.slice(0, ln.length - ln.trim().length);`
	`42`	`+ if (ln.trimStart() === ln) return "";`
	`43`	`+ return ln.slice(0, ln.length - ln.trimStart().length);`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`export function dedent(str: string): string {`