feat: expect LogLevelString instead of number as OTEL_LOG_LEVEL value

Signed-off-by: Naseem <[email protected]>

Author: Naseem

packages/opentelemetry-core/src/utils/environment.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { LogLevel } from '../common/types';
+import { LogLevel, LogLevelString } from '../common/types';
 
 export type ENVIRONMENT_MAP = { [key: string]: string | number };
 
@@ -79,7 +79,13 @@ export function parseEnvironment(values: ENVIRONMENT_MAP): ENVIRONMENT {
         break;
 
       case 'OTEL_LOG_LEVEL':
-        parseNumber(key, environment, values, LogLevel.ERROR, LogLevel.DEBUG);
+        let logLevel
+        const value = values[key]
+        if (value && typeof value === 'string') {
+          const logLevelString = value.toUpperCase() as LogLevelString
+          logLevel = LogLevel[logLevelString];
+        }
+        environment[key] = logLevel ?? LogLevel.ERROR;
         break;
 
       default:

packages/opentelemetry-core/test/common/ConsoleLogger.test.ts

@@ -119,7 +119,7 @@ describe('ConsoleLogger', () => {
 
     if (typeof process !== 'undefined' && process.release.name === 'node')
       it('should log with environmentally set level in Node', () => {
-        process.env.OTEL_LOG_LEVEL = '1'; // 1 maps to WARN
+        process.env.OTEL_LOG_LEVEL = 'WARN';
         const consoleLogger = new ConsoleLogger();
         consoleLogger.error('error called');
         assert.deepStrictEqual(errorCalledArgs, ['error called']);

packages/opentelemetry-core/test/utils/environment.test.ts

@@ -22,6 +22,7 @@ import {
 } from '../../src/utils/environment';
 import * as assert from 'assert';
 import * as sinon from 'sinon';
+import { LogLevel } from '../../src';
 
 let lastMock: ENVIRONMENT_MAP = {};
 
@@ -68,15 +69,23 @@ describe('environment', () => {
       mockEnvironment({
         FOO: '1',
         OTEL_NO_PATCH_MODULES: 'a,b,c',
-        OTEL_LOG_LEVEL: '1',
+        OTEL_LOG_LEVEL: 'WARN',
         OTEL_SAMPLING_PROBABILITY: '0.5',
       });
       const env = getEnv();
       assert.strictEqual(env.OTEL_NO_PATCH_MODULES, 'a,b,c');
-      assert.strictEqual(env.OTEL_LOG_LEVEL, 1);
+      assert.strictEqual(env.OTEL_LOG_LEVEL, LogLevel.WARN);
       assert.strictEqual(env.OTEL_SAMPLING_PROBABILITY, 0.5);
     });
 
+    it('should parse OTEL_LOG_LEVEL despite casing', () => {
+      mockEnvironment({
+        OTEL_LOG_LEVEL: 'waRn',
+      });
+      const env = getEnv();
+      assert.strictEqual(env.OTEL_LOG_LEVEL, LogLevel.WARN);
+    });
+
     it('should parse environment variables and use defaults', () => {
       const env = getEnv();
       Object.keys(DEFAULT_ENVIRONMENT).forEach(envKey => {