Fix #204, Check return value of calls to CFE_SB_Subscribe()
#205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbaker
approved these changes
Nov 27, 2024
dzbaker
added
the
CCB:Ready
dzbaker
reviewed
Dec 5, 2024
| @@ -47,6 +47,8 @@ | |||
| #define TO_LAB_NOOP_INF_EID 18 | |||
| #define TO_LAB_TBL_ERR_EID 19 | |||
| #define TO_LAB_ENCODE_ERR_EID 20 | |||
| #define TO_LAB_SUBSCRIBE_CMD_ERR_EID 21 | |||
There was a problem hiding this comment.
What was the purpose of adding these two new event IDs?
There was a problem hiding this comment.
Just to have unique error EIDs instead of overloading a previous one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CFE_SB_Subscribe()are missing return checks #204CFE_SB_Subscribe()and saves it to the status variable.Testing performed
GitHub CI actions all passing successfully.
Expected behavior changes
Failure of the calls to subscribe to the command and HK MIDs will set the status variable to an error state, and therefore halt further steps in the initialization.
System(s) tested on
Debian 12 using the current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt