Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #187, Zero-out global data during init + set RunStatus to APP_ERROR if init fails #188

Merged

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Tested locally with cFS suite + Ground System tool to confirm start-up and commands still working as expected.

Expected behavior changes
CFE_ES_ExitApp() will now be called if initialization fails, rather than simply exiting out of the function with the return statement.

System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

@chillfig chillfig added enhancement New feature or request CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 11, 2024
@dzbaker dzbaker added CCB:Approved Indicates approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 11, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 16, 2024
*Combines:*

cFE equuleus-rc1+dev131
to_lab equuleus-rc1+dev52

**Includes:**

*cFE*
- nasa/cFE#2548

*to_lab*
- nasa/to_lab#188

Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Joseph Hickey <[email protected]>
@dzbaker dzbaker merged commit 9c73e6d into nasa:main Apr 16, 2024
11 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 16, 2024
*Combines:*

cFE equuleus-rc1+dev131
to_lab equuleus-rc1+dev52

**Includes:**

*cFE*
- nasa/cFE#2548

*to_lab*
- nasa/to_lab#188

Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Joseph Hickey <[email protected]>
@thnkslprpt thnkslprpt deleted the fix-187-set-RunStatus-to-APP_ERROR-if-init-fails branch April 16, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates approval by CCB enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set RunStatus to CFE_ES_RunStatus_APP_ERROR if initialization fails
3 participants