Fix #78, Align use of Table/Tbl mnemonics #191
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -443,13 +443,13 @@ | |||
| /* Output CRC */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
| void SAMPLE_APP_GetCrc(const char *TableName) | |||
| void SAMPLE_APP_GetCrc(const char *TblName) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
|
CCB 3 November 2022: Preference would be to spell out "table" in all cases rather than spell it "tbl" (according to coding standards). Closing for now. |
Just to clarify @dzbaker - was the preference now for the all use of 'tbl' to be converted to 'table' (and 'TBL' to 'TABLE') in sample_app, or to close that issue without any action? |
Hi @thnkslprpt - Yes, the preferable format would ideally be 'TABLE' (typically, we'll spell out anything that is 6 or fewer characters). We discussed this at yesterday's CCB. Ideally, we would like to make them all consistent, but there's the risk that we'll miss something that will inadvertently result in something breaking somewhere, so we'd like to tackle formatting issues like these when we have more time/resources to fully test the changes. |
Cool no worries. |
Checklist
Describe the contribution
Fixes #78
Aligns use of Table/Tbl mnemonics in sample_app.
The macros and function parameters that used 'table' have been converted to 'tbl'.
I left the table struct (
SAMPLE_APP_Table_t) as is for now, because this is the more common convention in cFS.Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No impact on behavior.
Contributor Info
Avi Weiss @thnkslprpt