Return value of CFE_MSG_GetMsgId is not checked during ProcessCommandPacket or VerifyCmdLength

[asgibson]

Describe the bug
CFE_MSG_GetMsgId returns a status value to indicate success or failure of the call, but neither of the usages in the sample app check if it is successful nor do they state that the return value is ignored by design.

To Reproduce
N/A

Expected behavior
Sample app should either make use of the return value to verify success or should note the reason why this is not being done.

Code snips

sample_app/fsw/src/sample_app.c

Line 235 in d009197

CFE_MSG_GetMsgId(&SBBufPtr->Msg, &MsgId);

sample_app/fsw/src/sample_app.c

Line 442 in d009197

CFE_MSG_GetMsgId(MsgPtr, &MsgId);

System observed on:
N/A

Reporter Info
Alan Gibson NASA/GSFC 587

[thnkslprpt]

I don't know if any change is necessary here. Most uses of CFE_MSG_GetMsgId ignore the return value, and purely use it for its functionality.

Nevertheless, if it's considered desirable to illustrate consideration of the return value, given that this is the sample app, a minimalistic solution (for the first case) might be: