Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrun warning false alarm for CFE_MSG_Message_t #158

Open
ArielSAdamsNASA opened this issue Oct 6, 2021 · 1 comment
Open

Overrun warning false alarm for CFE_MSG_Message_t #158

ArielSAdamsNASA opened this issue Oct 6, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@ArielSAdamsNASA
Copy link

Describe the bug
Overrunning struct type CFE_MSG_Message_t of 16 bytes by passing it to a function which accesses it at byte offset 19 using argument 20UL.

Expected behavior
Fix overrun

Code snips

CFE_MSG_Init(&SAMPLE_APP_Data.HkTlm.TlmHeader.Msg, CFE_SB_ValueToMsgId(SAMPLE_APP_HK_TLM_MID),
sizeof(SAMPLE_APP_Data.HkTlm));

System observed on:
Coverity: https://scan.coverity.com/projects/arielsadamsnasa-cfs-jsf-rules?tab=overview

Reporter Info
Ariel Adams, ASRC Federal

@ArielSAdamsNASA ArielSAdamsNASA added the bug Something isn't working label Oct 6, 2021
@skliper
Copy link
Contributor

skliper commented Oct 7, 2021

Not a real overrun since there is sufficient memory allocated. Should still clean up to squash warning, switching to enhancement. Related to nasa/cFE#1992.

@skliper skliper added enhancement New feature or request and removed bug Something isn't working labels Oct 7, 2021
@skliper skliper changed the title Overrun for CFE_MSG_Message_t Overrun warning false alarm for CFE_MSG_Message_t Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants