-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #604, Add ut_assert address equal macro #605
Fix #604, Add ut_assert address equal macro #605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use cpuaddr instead of void *? I duno the diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think void*
is fine but I just want to confirm/check if this has been used/tested with a const
pointer? I think it should be fine as C does allow you to cast a const void*
back to a void*
as long as you are explicit about it, and this is.
Just tested w:
and it compiled/ran/passed. On Ubuntu 18.04. |
Fix nasa#494, Updates CFE_SB_GetLastSenderID to check if message has been sent on pipe
Describe the contribution
Fix #604 - adds the macro
Testing performed
Used the macro in work related to nasa/cFE#903 (built and ran unit tests locally using it)
Expected behavior changes
Additional macro available
System(s) tested on
Additional context
None.
Third party code
None.
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC