Skip to content

Fix #1492, Correct README.md OSAL User's Guide links #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

leighgarbs
Copy link
Contributor

@leighgarbs leighgarbs commented Jan 5, 2025

Checklist (Please check before submitting)

Describe the contribution
Fixes #1492

Testing performed
Steps taken to test the contribution:

  1. Follow the modified README.md links at https://github.com/leighgarbs/osal/blob/fix-1492-correct-readme-osal-users-guide-links/README.md

Expected behavior changes
The README.md links to the OSAL User's Guide link to the OSAL User's Guide.

System(s) tested on

  • macOS laptop in Chrome browser

Contributor Info - All information REQUIRED for consideration of pull request
Leigh Garbs, NASA

@leighgarbs leighgarbs force-pushed the fix-1492-correct-readme-osal-users-guide-links branch from 7b49f2c to d1ac097 Compare January 5, 2025 03:02
@leighgarbs leighgarbs changed the title Fix #1492, correct README.md OSAL User's Guide links Fix #1492, Correct README.md OSAL User's Guide links Jan 5, 2025
@leighgarbs
Copy link
Contributor Author

leighgarbs commented Jan 5, 2025

I could contribute as an individual and sign the Individual CLA, but I'm a NASA employee and would like to contribute as a NASA employee. Do NASA employees have to sign a CLA?

@dzbaker
Copy link
Collaborator

dzbaker commented Jan 16, 2025

I could contribute as an individual and sign the Individual CLA, but I'm a NASA employee and would like to contribute as a NASA employee. Do NASA employees have to sign a CLA?

Hi @leighgarbs, thanks for your contribution! NASA employees do not need to sign a CLA.

@leighgarbs leighgarbs marked this pull request as ready for review January 16, 2025 19:21
@dzbaker dzbaker added the CCB:Approved Indicates code review and approval by community CCB label Feb 6, 2025
dzbaker added a commit to nasa/cFS that referenced this pull request Feb 25, 2025
*Combines:*

osal equuleus-rc1+dev97
sample_app equuleus-rc1+dev50

**Includes:**

*osal*
-nasa/osal#1493

*sample_app*
-nasa/sample_app#235

Co-authored by: Leigh Garbs <[email protected]>
Co-authored by: Anh Van <[email protected]>
@dzbaker dzbaker mentioned this pull request Feb 25, 2025
2 tasks
dzbaker added a commit to nasa/cFS that referenced this pull request Feb 25, 2025
*Combines:*

osal equuleus-rc1+dev97
sample_app equuleus-rc1+dev50
cFS-GroundSystem equuleus-rc1+dev18

**Includes:**

*osal*
-nasa/osal#1493

*sample_app*
-nasa/sample_app#235

*cFS-GroundSystem*
-nasa/cFS-GroundSystem#249

Co-authored by: Leigh Garbs <[email protected]>
Co-authored by: Anh Van <[email protected]>
Co-authored by: Voicu Ioan Vladut <[email protected]>
@dzbaker dzbaker merged commit 3d92e79 into nasa:main Feb 25, 2025
19 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Feb 25, 2025
*Combines:*

osal equuleus-rc1+dev97
sample_app equuleus-rc1+dev50
cFS-GroundSystem equuleus-rc1+dev18

**Includes:**

*osal*
-nasa/osal#1493

*sample_app*
-nasa/sample_app#235

*cFS-GroundSystem*
-nasa/cFS-GroundSystem#249

Co-authored by: Leigh Garbs <[email protected]>
Co-authored by: Anh Van <[email protected]>
Co-authored by: Voicu Ioan Vladut <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect OSAL User's Guide README links
2 participants