-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1244, Add RTEMS timebase callback wrapper #1276
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepepr08
added
the
CCB:Ready
Pull request is ready for discussion at the Configuration Control Board (CCB)
label
Aug 1, 2022
skliper
approved these changes
Aug 1, 2022
jphickey
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with minor update request (remove cast)
CCB 3 Aug 2022: Approved pending removal of rtems_task_entry typecast. |
dzbaker
added
CCB:Approved
Indicates code review and approval by community CCB
and removed
CCB:Ready
Pull request is ready for discussion at the Configuration Control Board (CCB)
labels
Aug 3, 2022
dzbaker
added a commit
that referenced
this pull request
Aug 4, 2022
Fix #1244, Add RTEMS timebase callback wrapper
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 4, 2022
*Combines:* cfe v7.0.0-rc4+dev157 osal v6.0.0-rc4+dev103 *Includes* - nasa/cFE#2129, use correct loop var in add_cfe_app_dependency - nasa/cFE#2117, Automatic suppression of flooding events - nasa/cFE#2126, Remove stray TODO in UT - nasa/osal#1274, Remove stray terminators - nasa/osal#1276, Add RTEMS timebase callback wrapper Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Jose Martinez Pedraza <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 4, 2022
*Combines:* cfe v7.0.0-rc4+dev157 osal v6.0.0-rc4+dev103 *Includes* - nasa/cFE#2129, use correct loop var in add_cfe_app_dependency - nasa/cFE#2117, Automatic suppression of flooding events - nasa/cFE#2126, Remove stray TODO in UT - nasa/osal#1274, Remove stray terminators - nasa/osal#1276, Add RTEMS timebase callback wrapper Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Jose Martinez Pedraza <[email protected]>
Merged with PR #1277 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #1244 by creating a wrapper function to convert timebase callback task argument from rtems_task_argument into osal_id_t
Testing performed
Steps taken to test the contribution:
OMIT_DEPRECATED = true
andMISSION_RESOURCEID_MODE = "STRICT"
for RTEMS/GR740System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Jose F Martinez Pedraza / NASA GSFC code 582