Fix #1237, avoid calling memchr() with unknown size buffer #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some systems, passing a large size value to memchr() causes it to return NULL, even if the char is guaranteed to be found within the actual valid buffer memory. This modifies the string buffer comparison function to actively check for this sentinel value and use "strlen()" instead.
skliper
approved these changes
Mar 25, 2022
skliper
added
the
unit-test
jphickey
added
the
CCB:Ready
|
Note - format check issue appears to be a problem that was already in the build (not caused by this PR) |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Mar 25, 2022
Co-authored-by: Joseph Hickey <[email protected]>
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Mar 25, 2022
Co-authored-by: Joseph Hickey <[email protected]>
2 tasks
|
Approved |
dmknutsen
added
the
CCB:Approved
astrogeco
removed
the
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
In some systems, passing a large size value to memchr() causes it to return NULL, even if the char is guaranteed to be found within the actual valid buffer memory.
This modifies the string buffer comparison function to actively check for this sentinel value and use "strlen()" instead.
Fixes #1237
Testing performed
Build and sanity check, run all tests on both Ubuntu (latest version) and CentOS 7 VM
Expected behavior changes
Tests pass in both systems (no SEGV on CentOS 7)
System(s) tested on
Ubuntu 21.10
CentOS 7
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.