Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open telemetry in new tab does not work in ExampleDataVisualizationSourcePlugin #7382

Closed
2 of 7 tasks
davetsay opened this issue Jan 17, 2024 · 2 comments · Fixed by #7384
Closed
2 of 7 tasks

Open telemetry in new tab does not work in ExampleDataVisualizationSourcePlugin #7382

davetsay opened this issue Jan 17, 2024 · 2 comments · Fixed by #7384
Labels
severity:trivial type:bug verified Tested or intentionally closed
Milestone

Comments

@davetsay
Copy link
Contributor

davetsay commented Jan 17, 2024

Summary

Console error on Open In New Tab action

Error: Cannot make key string from null identifier
    at Object.Au [as makeKeyString] (openmct.js:2:2853154)
    at Yb.makeKeyString (openmct.js:2:2958013)
    at Yb.get (openmct.js:2:2952992)
    at Yb.getOriginalPath (openmct.js:2:2958444)
    at Proxy.getTelemetryPath (openmct.js:2:3547040)
    at Proxy.openInNewTab (openmct.js:2:3547101)
    at o.showMenu.$r.onClick.t.<computed>.t.<computed> (openmct.js:2:3548502)
    at ci (openmct.js:2:2717623)
    at li (openmct.js:2:2717702)
    at HTMLLIElement.i (openmct.js:2:2787671)

Expected vs Current Behavior

Expected: Open MCT should open a new browser tab and navigate to the telemetry used in the Data Visualization.
Current: console error

Steps to Reproduce

  1. See instructions for Data inspector visualization missing renderWhenVisible #7283
  2. Use the Open In New Tab as seen in the attached below screenshot
  3. Should see expected behavior above

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available? Just go to the telemetry, or use the Open In New Tab action from the tree
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

image

@davetsay
Copy link
Contributor Author

davetsay commented Feb 8, 2024

For testing instructions see Steps to Reproduce in the description where expected behavior should be that as listed in Expected vs Current Behavior section.

@davetsay davetsay removed the needs:test instructions Missing testing notes label Feb 8, 2024
@ozyx
Copy link
Contributor

ozyx commented Mar 5, 2024

Verified fixed - Testathon 3/25/24

Tested this locally and it works as expected now

@ozyx ozyx added the verified Tested or intentionally closed label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:trivial type:bug verified Tested or intentionally closed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants