Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent time conductor shows local clock time when remote clock selected #7223

Closed
1 of 7 tasks
michaelrogers opened this issue Nov 9, 2023 · 3 comments · Fixed by #7191
Closed
1 of 7 tasks

Independent time conductor shows local clock time when remote clock selected #7223

michaelrogers opened this issue Nov 9, 2023 · 3 comments · Fixed by #7191
Labels
Milestone

Comments

@michaelrogers
Copy link
Contributor

michaelrogers commented Nov 9, 2023

I found a scenario in which the independent time conductor for a plot can show the local clock time in the conductor itself, even though the plot is ticking on the correct time.

Relates to VIPER-398

Steps to Reproduce

  1. Navigate to an overlay plot
  2. Observe that the independent time conductor is configured to use remote-clock, while the global time conductor is following local clock.
  3. Observe that the independent time conductor shows wall-clock, even though the plot shows real-time data in remote-time.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@michaelrogers
Copy link
Contributor Author

How to Test

  1. Navigate to an overlay plot
  2. Observe the mode of the global and independent time conductor
  3. Set them so they are different (i.e. global local clock and ITC remote clock)
  4. Observe that the time conductors display an appropriate time value and the ITC matches the plot mode

@khalidadil
Copy link
Contributor

@michaelrogers Does this work with sine wave generators?

@unlikelyzero
Copy link
Collaborator

Verified Testathon 11/13/23 -- Global clock remains unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants