Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Export as JSON] Issues with items that have identifiers stored in configuration #6561

Closed
3 of 7 tasks
jvigliotta opened this issue Apr 6, 2023 · 2 comments · Fixed by #6562
Closed
3 of 7 tasks
Labels
needs:e2e Needs an e2e test type:bug
Milestone

Comments

@jvigliotta
Copy link
Contributor

Summary

There is an issue with exporting display layouts (or any item that has configuration that stores identifiers). When we export we find and replace old key strings with new key strings, but this misses the case where identifiers are used (such as above mentioned configuration). This causes odd issues, like display layout items "pancaking" 1:1 coordinates of the grid. This fix adds checks for identifier objects as well and will replace those.

Expected vs Current Behavior

Identifiers should have always been included in the replacement, they are not included in the replacement.

Steps to Reproduce

  1. have an linked/aliased item in a display layout that also has a namespace in it's identifier
  2. export the item
  3. import the item
  4. notice that the positions for aliased items are lost

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@jvigliotta jvigliotta self-assigned this Apr 6, 2023
@jvigliotta jvigliotta mentioned this issue Apr 6, 2023
15 tasks
@unlikelyzero unlikelyzero added this to the Target:2.2.2 milestone Apr 17, 2023
@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Apr 17, 2023
@unlikelyzero unlikelyzero added the needs:test instructions Missing testing notes label Apr 17, 2023
@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Apr 17, 2023

Will need to test on stable and testathon

@jvigliotta can you provide one for us to import/export?

@unlikelyzero
Copy link
Collaborator

Can be closed. Still issues found #6601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:e2e Needs an e2e test type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants