Fix #85, Add checks for all return values from fseek() #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
fseek()
in 5 locations where this was absent.Note: in these cases, an error return from
fseek()
seems extremely unlikely (unless the input data is corrupted somehow) so these checks are mostly just to squash the warnings.Testing performed
GitHub CI actions (incl. Codeql Build etc.) all passing successfully excl. CodeQL-security for apparently pre-existing issues that are being flagged now.
Expected behavior changes
In cases of error (non-zero) return from
fseek()
the error info will be printed and early return withFAILED
will occur.Contributor Info
Avi Weiss @thnkslprpt