-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #96, Check returns from CFE calls during init #132
Fix #96, Check returns from CFE calls during init #132
Conversation
0b50c09
to
1b78541
Compare
You have successfully added a new CppCheck configuration |
You have successfully added a new CodeQL-coding-standard configuration |
You have successfully added a new CodeQL-security configuration |
1b78541
to
9f37dde
Compare
@thnkslprpt Can you replace CI_LAB_INIT_INF_EID with CI_LAB_STARTUP_INF_EID? |
daca072
to
d5e6f3c
Compare
d5e6f3c
to
5c3d843
Compare
@dmknutsen I rebased to main and all passing now (was able to leave it with the updated CI_LAB_INIT_INF_EID version [90% of the cFS apps/components use INIT rather than STARTUP]) - is that cool? |
Yep - that works. Thanks Avi! |
Checklist
Describe the contribution
CFE_EVS_Register()
,CFE_SB_CreatePipe()
, andCFE_SB_Subscribe()
during CI_LAB initialization sequence that are!= CFE_SUCCESS
will now generate an EVS event reporting the error.Testing performed
Build + Run cFS locally to confirm CI_LAB still running fine with these changes.
Also ran with inverse for each event (checking if
status == CFE_SUCCESS
) to confirm structure and format of events is fine - they are shown here:Expected behavior changes
Program logic not changed, but new events reports will now be generated for failures generated by these CFE calls.
System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch cFS bundle.
Contributor Info
Avi @thnkslprpt