Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1635, Change CI to use Test Log. #1660

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Fix #1635, Change CI to use Test Log. #1660

merged 2 commits into from
Jul 14, 2021

Conversation

zanzaben
Copy link
Contributor

Describe the contribution
Fixes #1635
Change CI to use the test log file instead of tee.

Testing performed
Build and run unit test

Expected behavior changes
No impact to behavior

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

skliper
skliper previously requested changes Jul 12, 2021
View reviewed changes
.github/workflows/functional-tests.yml Outdated Show resolved Hide resolved
@zanzaben zanzaben added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jul 14, 2021
@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Jul 14, 2021
@astrogeco
Copy link
Contributor

astrogeco commented Jul 14, 2021 •
edited
Loading

CCB:2021-07-14 APPROVED

  • The purpose of making a tmp file and renaming is to check for its existence
  • Worried about reading a file that's in the process of being written
  • Consider shrinking the 15 minutes wait
  • There's a danger of a long running test giving a false failure
  • Future improvement: encapsulate RUN commands into a shell script

@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jul 14, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate July 14, 2021 18:18
@astrogeco astrogeco merged commit f7ea468 into nasa:integration-candidate Jul 14, 2021
@astrogeco astrogeco mentioned this pull request Jul 14, 2021
Merged
astrogeco added a commit to nasa/cFS that referenced this pull request Jul 19, 2021
@astrogeco
IC:2021-07-20, Add cFE PRs
ae6289e 
nasa/cFE#1664, remove default .dat extension
nasa/cFE#1660, Change CI to use Test Log.
@astrogeco astrogeco mentioned this pull request Jul 20, 2021
Merged
astrogeco added a commit to nasa/cFS that referenced this pull request Jul 21, 2021
@astrogeco @skliper
@jphickey @zanzaben @oliverhamburger
IC:2021-07-20, Update cfe and osal
b2f3605 
**Combines**

nasa/cFE#1665, v6.8.0-rc1+dev762
nasa/osal#1113, v5.1.0-rc1+dev573

**Includes**

nasa/cFE#1664, remove default .dat extension
nasa/cFE#1660, Change CI to use Test Log.
nasa/cFE#1670, Update API doxygen list
nasa/cFE#1671, update documentation for CFE_ES_GetPoolBufInfo
nasa/cFE#1674, CFE_SB_MsgHdrSize returns size_t
nasa/cFE#1668, improve SB coverage test
nasa/cFE#1694, correct function name in UT_BSP_Unlock

nasa/osal#1106, Add independent OS_rename functional test parameter checks

Co-authored-by: Jacob Hageman <[email protected]>
Co-authored-by: Joseph Hickey <[email protected]>
Co-authored-by: Alex Campbell <[email protected]>
Co-authored-by: Oliver Hamburger <[email protected]>
@zanzaben zanzaben deleted the fix1635_update_ci_to_log_file branch August 13, 2021 13:19
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper left review comments

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Milestone
Caelum
Development

Successfully merging this pull request may close these issues.

Update the CI functional test to use the unit test report file
3 participants
@zanzaben @astrogeco @skliper