Fix #146, set revision number to 99 #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per CFE/CFS versioning patterns, development software should report itself as revision 99 to avoid confusion with released versions.
jphickey
added
the
CCB:Ready
|
Merging, but I wonder if we should update to using 0xFF like you started doing in osal... |
|
OSAL was non-compliant w/ documented versioning scheme. I'm fine with either 99 or 0xFF, the important part to me is that we are consistent (OSAL was the outlier in this case). |
astrogeco
added
CCB:Approved
and removed
CCB:Ready
|
CCB:2022-01-19 APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Per CFE/CFS versioning patterns, development software should report itself as revision 99 to avoid confusion with released versions.
Fixes #146
Testing performed
Build and sanity check CF
Expected behavior changes
Revision reported as 99 now, example boot event:
System(s) tested on
Ubuntu 21.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.