Fix #94, move all bitfields into codec #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing outside of the codec code should need to know about the bitfields in the CFDP protocol definition. Everything else uses logical values. This moves all DECLARE_FIELD macros into cf_codec.c and removes cf_field.h.
jphickey
added
the
CCB:Ready
skliper
approved these changes
Jan 18, 2022
astrogeco
added
CCB:Approved
and removed
CCB:Ready
|
CCB:2022-01-19 APPROVED
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Nothing outside of the codec code should need to know about the bitfields
in the CFDP protocol definition. Everything else uses logical values.
This moves all DECLARE_FIELD macros into cf_codec.c and removes cf_field.h.
Fixes #94
Fixes #65
Testing performed
Build and sanity check CF
Run all unit tests
Run some file transfers
Expected behavior changes
None, code clean up
System(s) tested on
Ubuntu 21.10
Additional context
This just puts these definitions on the "need to know" basis, by not exposing them outside the only file where they matter.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.