Fix #164, consistent "chunk" test sizes #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use a random uint16 to size the structure that is allocated on the stack. Pick a reasonable size that is not likely to overrun the stack, and use it. This fixes a crash/stack overrun issue when running on RTEMS.
jphickey
added
the
CCB:Ready
astrogeco
approved these changes
Jan 18, 2022
astrogeco
removed
the
CCB:Ready
|
CCB:2022-01-19 APPROVED
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Do not use a random uint16 to size the structure that is allocated on the stack. Pick a reasonable size that is not likely to overrun
the stack, and use it.
This fixes a crash/stack overrun issue when running on RTEMS.
Fixes #164
Testing performed
Build and sanity check CF on PC-RTEMS
Expected behavior changes
Tests pass
System(s) tested on
RTEMS 4.11.3 via QEMU+pc686 BSP
Additional context
This only fixes the random values that caused a stack overrun/crash. Would still recommend fixing other use of random numbers in tests.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.